Fix deployment missing If condition for tolerations #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rainest
requested changes
Jul 6, 2022
|
@ammartins it looks like your local git installation isn't configured with your email. You'll need to set that to match your GitHub email, edit commits to use your new author info, and then sign the CLA. |
Will do. |
If you use ArgoCD to deploy this helm chart and leave toleration empty, helm chart keeps getting repor as not sync
If you use ArgoCD to deploy this helm chart and leave toleration empty, helm chart keeps getting repor as not sync
ammartins
force-pushed
the
fix-deployment-missing-condition-tolerations
branch
from
a427e63
to
92fe31f
Compare
Co-authored-by: Travis Raines <571832+rainest@users.noreply.github.com>
ammartins
force-pushed
the
fix-deployment-missing-condition-tolerations
branch
from
b53d8f8
to
ddda098
Compare
rainest
approved these changes
Jul 6, 2022
sgrzemski
pushed a commit
to sgrzemski/charts
that referenced
this pull request
Jul 11, 2022
Co-authored-by: Travis Raines <571832+rainest@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use ArgoCD to deploy this helm chart and leave toleration empty, the helm chart keeps getting reported as not sync
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.