Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(env) change file logs to stdout/stderr #634

Merged
merged 2 commits into from
Jul 7, 2022
Merged

fix(env) change file logs to stdout/stderr #634

merged 2 commits into from
Jul 7, 2022

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jul 7, 2022

What this PR does / why we need it:

Default all logs to stderr/stdout or off. The Docker distributions hit most of these already, so some of these settings are redundant, but there are several that we never changed at build time.

Special notes for your reviewer:

Before:

bash-5.1$ grep access_log .kong_env
portal_api_access_log = /dev/stdout
proxy_stream_access_log = logs/access.log basic
portal_gui_access_log = logs/portal_gui_access.log
admin_gui_access_log = /dev/stdout
proxy_access_log = /dev/stdout
admin_access_log = /dev/stdout
status_access_log = off

bash-5.1$ grep error_log .kong_env 
portal_api_error_log = /dev/stderr
admin_gui_error_log = /dev/stderr
status_error_log = logs/status_error.log
proxy_stream_error_log = logs/error.log
admin_error_log = /dev/stderr
proxy_error_log = /dev/stderr
portal_gui_error_log = logs/portal_gui_error.log

After:

bash-5.1$ grep access_log .kong_env
portal_api_access_log = /dev/stdout
proxy_access_log = /dev/stdout
proxy_stream_access_log = /dev/stdout basic
status_access_log = off
portal_gui_access_log = /dev/stdout
admin_gui_access_log = /dev/stdout
admin_access_log = /dev/stdout

bash-5.1$ grep error_log .kong_env
portal_api_error_log = /dev/stderr
proxy_stream_error_log = /dev/stderr
status_error_log = /dev/stderr
admin_gui_error_log = /dev/stderr
portal_gui_error_log = /dev/stderr
admin_error_log = /dev/stderr
proxy_error_log = /dev/stderr

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@rainest rainest requested a review from a team as a code owner July 7, 2022 16:55
Set log locations in autoenv. Many of these default to stdout and stderr
by default on Docker distributions, but for whatever reason there are
several that have been omitted.
@rainest rainest disabled auto-merge July 7, 2022 18:34
@rainest rainest enabled auto-merge (squash) July 7, 2022 18:35
@rainest rainest merged commit 6d37517 into main Jul 7, 2022
@rainest rainest deleted the fix/log-out branch July 7, 2022 18:42
sgrzemski pushed a commit to sgrzemski/charts that referenced this pull request Jul 11, 2022
Set log locations in autoenv. Many of these default to stdout and stderr
by default on Docker distributions, but for whatever reason there are
several that have been omitted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants