Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove terminationGracePeriodSeconds from KIC's container spec #640

Merged
merged 1 commit into from
Jul 11, 2022
Merged

fix: remove terminationGracePeriodSeconds from KIC's container spec #640

merged 1 commit into from
Jul 11, 2022

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jul 11, 2022 •
edited

What this PR does / why we need it:

This PR removes terminationGracePeriodSeconds from KIC's container spec (introduced in #597) since that field is only applicable to pod spec.

Which issue this PR fixes

Checklist

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@pmalek pmalek added the bug Something isn't working label Jul 11, 2022
@pmalek pmalek self-assigned this Jul 11, 2022
@pmalek pmalek force-pushed the remove-terminationGracePeriodSeconds-from-kic-container-spec branch from 36da665 to 20398f4 Compare July 11, 2022 08:15
@pmalek pmalek marked this pull request as ready for review July 11, 2022 16:16
@pmalek pmalek requested a review from a team as a code owner July 11, 2022 16:16
@pmalek pmalek enabled auto-merge (squash) July 11, 2022 16:17
@pmalek pmalek merged commit e25dccb into main Jul 11, 2022
@pmalek pmalek deleted the remove-terminationGracePeriodSeconds-from-kic-container-spec branch July 11, 2022 16:18
@pmalek pmalek mentioned this pull request Jul 11, 2022
Closed
sgrzemski pushed a commit to sgrzemski/charts that referenced this pull request Jul 11, 2022
@pmalek @sgrzemski
fix: remove terminationGracePeriodSeconds from KIC's container spec (K…
914d3ea 
…ong#640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainest rainest rainest approved these changes

Assignees

@pmalek pmalek

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

terminationGracePeriodSeconds: field not declared in schema
2 participants
@pmalek @rainest