Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(values) added extraObjects (FTI-4149) #652

Merged
merged 4 commits into from
Aug 3, 2022

Conversation

andrewgkew
Copy link
Contributor

What this PR does / why we need it:

Added capability to create additional k8s resources as part of the helm release

Signed-off-by: Andrew Kew andrew@quadcorps.co.uk

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #
    FTI-4149

Special notes for your reviewer:

@scseanchow

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

Added capability to create additional k8s resources as part of the helm release

Signed-off-by: Andrew Kew <andrew@quadcorps.co.uk>
Signed-off-by: Andrew Kew <andrew@quadcorps.co.uk>
@andrewgkew andrewgkew requested a review from a team as a code owner July 27, 2022 16:19
@rainest rainest enabled auto-merge (squash) August 3, 2022 00:12
@rainest rainest merged commit 1ccde00 into Kong:main Aug 3, 2022
@scseanchow
Copy link

scseanchow commented Aug 3, 2022

Thank you @andrewgkew for the submission. For anyone coming to this PR after the fact, although we have implemented extraResources as a way to include additional Kubernetes resources, but best practices encourages the use of umbrella charts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants