Upgrade CRDs to apiextensions.k8s.io/v1

[rifelpet]

K8s 1.16 promoted CustomResourceDefinition from v1beta1 to v1

See the 3rd changelog bullet point for details as well as the blog post overview.

Kong should upgrade the CRDs to v1 to take advantage of these new features. I'm not sure what the support policy is for these charts since it would require k8s 1.16. Perhaps you can use helm's Capabilities.Has if older k8s versions should continue to be supported?

[rainest]

@hbagdi any thoughts from the controller end? Should our CRDs require anything beyond a bump to the API version used?

On the Helm front, this may be difficult. Although the capabilities info is fine for this purpose, Helm 3 CRDs aren't templated, and I don't think there's any good way to handle the version split without templating. https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#some-caveats-and-explanations effectively states that handling this is an open question to be answered later.

[hbagdi]

The controller should be fine. We can quickly test if required.
We will need to make some changes to CRD to make them structured.

Regarding, lack of support from Helm, can we open a Github issue on helm/helm please?
A lot of charts will run into this and having some consensus around the solution will go a long way for the entire community.

[rainest]

Revisiting this since it will come up again in the Kong chart 1.6 release. Helm behavior remains unchanged, but we'll instruct users that they need to upgrade manually in UPGRADE.md.

Handling this in Helm is an open, heavily-debated question: helm/helm#5871

Our other option absent any changes to manage the CRDs via a subchart. This adds more overhead, but allows upgrading CRDs and managing them in an independent release if desired. As the CRD chart would not require any settings, it should avoid the more cumbersome aspects of using subcharts. It further works around scenarios where the Kong operators may not have permissions to manage CRDs, one of the major sticking points for the upstream Helm proposal.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[rainest]

Handled in 2.4.