Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart example yaml #944

Open
akoshok1 opened this issue Nov 15, 2023 · 4 comments
Open

Update quickstart example yaml #944

akoshok1 opened this issue Nov 15, 2023 · 4 comments
Assignees

Comments

@akoshok1
Copy link

When trying https://raw.githubusercontent.com/Kong/charts/main/charts/kong/example-values/doc-examples/quickstart-enterprise-licensed-aio.yaml

We get:
* admission webhook "vingress.elbv2.k8s.aws" denied the request: invalid ingress class: IngressClass.networking.k8s.io "kong" not found
* admission webhook "vingress.elbv2.k8s.aws" denied the request: invalid ingress class: IngressClass.networking.k8s.io "kong" not found
* admission webhook "vingress.elbv2.k8s.aws" denied the request: invalid ingress class: IngressClass.networking.k8s.io "kong" not found
*
This makes sense. We set ingressController.ingressClass to default, and not kong. And then in manager.ingressClassName portal.ingressClassName and portalapi.manager.ingressClassName we refer to kong, and not default.

May I suggest we:
1-alter ingressController.ingressClass to kong
2-For consistency, also set admin.ingressClassName to kong

@randmonkey
Copy link
Contributor

The ingress classes becomes inconsistent after da4889f. We should use the same ingress class: all use default (the original value) or all use kong.

@akoshok1
Copy link
Author

Perhaps kong is a better choice, as there is a good chance default may already be used in clusters we install to.

@rainest
Copy link
Contributor

rainest commented Nov 16, 2023

Per chat, @mheap said he wanted to review this guide overall as part of fixing this, so assigning to him.

@akoshok1
Copy link
Author

While at it, let us please remove the two hostport settings which cause issues in EKS w/ Fargate and we do not use in other examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants