Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] customize: allow --server instead of --only-server #453

Open
Tieske opened this issue Feb 18, 2021 · 0 comments
Open

[FEAT] customize: allow --server instead of --only-server #453

Tieske opened this issue Feb 18, 2021 · 0 comments
Assignees

Comments

@Tieske
Copy link
Member

Tieske commented Feb 18, 2021

When creating a customized version of an image and including non-public plugins (as rocks), the implementation will use the --only-server flag to prevent it from reaching out to public LuaRocks servers.

Though this is a secure solution, it is also limiting. If the private plugin relies on external modules, it requires you to download all those rocks an store them locally to add to the local server.

By specifying --server instead of --only-server it would first try the local one, for the none public ones, and then if not found, try the public ones to fetch any dependencies.

This code:

return " --only-server=http://localhost:8080 "

@Tieske Tieske self-assigned this Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants