Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl --resolve commands in KIC's guides don't work for minikube's PROXY_IP #5200

Closed
2 tasks done
czeslavo opened this issue Feb 23, 2023 · 2 comments
Closed
2 tasks done
Assignees
Labels
area/docs Kubernetes Team Kubernetes task tracking (including KIC)

Comments

@czeslavo
Copy link
Contributor

czeslavo commented Feb 23, 2023

Where is the problem?

https://docs.konghq.com/kubernetes-ingress-controller/2.8.x/guides/getting-started/

What happened?

A user was trying to complete the Getting started with KIC guide having a Minikube Kong setup created following the Kong Ingress on Minikube guide. When he got to the point where a route is to be tested with curl -i http://kong.example/echo --resolve kong.example:80:$PROXY_IP, the command didn't work.

The reason it couldn't work is the $PROXY_IP that he got from the Minikube guide was a full URL (e.g. http://192.168.99.100:32728), not just an IP address. It resulted in curl -i http://kong.example/echo --resolve kong.example:80:http://192.168.99.100:32728 which is invalid.

What did you expect to happen?

The curl commands in KIC guides that use --resolve flag should take into account that the $PROXY_IP might be not just an IP address. That could be achieved by replacing --resolve kong.example:80:$PROXY_IPs with -H "Host: kong.example". Also changing the $PROXY_IP name to better reflect its nature would be advised (e.g. to $PROXY_URL).

An alternative would be to enforce the $PROXY_IP to always be (as it's named) an IP address (requiring changes in the Minikube guide).

Code of Conduct and Community Expectations

  • I agree to follow this project's Code of Conduct
  • I agree to abide by the Community Expectations
@czeslavo czeslavo added Kubernetes Team Kubernetes task tracking (including KIC) area/docs labels Feb 23, 2023
@Rajakavitha1 Rajakavitha1 mentioned this issue Jul 25, 2023
2 tasks
@Rajakavitha1
Copy link
Contributor

Rajakavitha1 commented Jul 25, 2023

Hi @czeslavo !! I tried to address the issues in these two PRs after testing and validating. #5842 and #5844
minikubeKIC-test.txt
. Please take a look and let me know if any changes need to be made.

@czeslavo
Copy link
Contributor Author

@Rajakavitha1 Thank you for your contribution! Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Kubernetes Team Kubernetes task tracking (including KIC)
Projects
None yet
Development

No branches or pull requests

2 participants