Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Environment Variables] Base environment tag not saved #5858

Closed
1 task done
viico opened this issue Mar 22, 2023 · 10 comments
Closed
1 task done

[Environment Variables] Base environment tag not saved #5858

viico opened this issue Mar 22, 2023 · 10 comments
Labels
B-bug Bug: general classification S-unverified Status: Unverified by maintainer

Comments

@viico
Copy link

viico commented Mar 22, 2023

Expected Behavior

Tag body attribute saved when we change Request field.

Actual Behavior

When I change the Request in a tag (type Body Attribute) present in my base environment it is not saved. If i close the modal and reopen the request is still the one before à change it.

Reproduction Steps

  1. Set a variable with a tag (type Body Attribute) in the base environment
  2. Close the environment modal
  3. Reopen the base environment and change the request in the tag
  4. Close the environment modal
  5. Reopen the base environment => it's not the new request selectec

Is there an existing issue for this?

Additional Information

No response

Insomnia Version

2023.1.0

What operating system are you using?

Windows

Operating System Version

Windows 10 Entreprise

Installation method

download from insomnia.rest

Last Known Working Insomnia version

No response

@viico viico added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels Mar 22, 2023
@viico
Copy link
Author

viico commented Mar 22, 2023

One workaround is to modify the base environment (add / modify / remove another variable).

@mhmmd-ysf
Copy link

I'm having the same issue here

Version: Insomnia 2023.1.0
Build date: 3/9/2023
OS: Windows_NT x64 10.0.22000
Electron: 22.0.0
Node: 16.17.1
V8: 10.8.168.20-electron.0
Architecture: x64

@fanch317
Copy link

fanch317 commented Jun 29, 2023

I have same issue here.

This issue only happens when you update a parameter on a function (tested with Body Attribute and a SHA512)

Recording 2023-06-29 at 12 02 00

Version: Insomnia 2023.3.0
Build date: 27/06/2023
OS: Windows_NT x64 10.0.19045
Electron: 22.3.11
Node: 16.17.1
V8: 10.8.168.25-electron.0
Architecture: x64

Related to #5612

@tlund101
Copy link

This is fixed by #6011 A workaround is to just click in the json and click back out of it to trigger the onBlur event.

@mikebridge
Copy link

This behaviour is recurring for me after upgrading to 2023.5.7. the onBlur workaround doesn't seem to help---none of my changes are reflected after closing the editing window.

@mikebridge
Copy link

The only way I have found to get it to change variables is to close Insomnia entirely after editing a variable and reload the whole app.

@viico
Copy link
Author

viico commented Sep 5, 2023

The only way I have found to get it to change variables is to close Insomnia entirely after editing a variable and reload the whole app.

Hi, my precedent workaround didn't work for you ?

One workaround is to modify the base environment (add / modify / remove another variable).

@mhmmd-ysf
Copy link

One workaround is to modify the base environment (add / modify / remove another variable).

Creating a dedicated property for env variable update seems to be the best option currently.

{
  ...
  "dedicated_variable": "update this value if you only want to change env tags"
}

@mikebridge
Copy link

This appears to have reverted after upgrading to 8.5.0. To reproduce, I do an Edit Tag on an existing Response: reference values form other request's responses, then select a Request, then change the filter on Attribute: Body Attribute to the value $.access_token and verify Live Preview has a value, then click Done.

When I reopen, all my changes are gone.

@gatzjames
Copy link
Contributor

Closing as this should now be fixed in 8.5.1 by #6941
Thanks everyone for the feedback and especially @mikebridge for bringing it up on the updates of the environment modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification S-unverified Status: Unverified by maintainer
Projects
None yet
Development

No branches or pull requests

6 participants