Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request switcher keyboard shortcuts not working #6301

Closed
1 task done
JeroenVdb opened this issue Aug 16, 2023 · 35 comments · Fixed by #6968
Closed
1 task done

Request switcher keyboard shortcuts not working #6301

JeroenVdb opened this issue Aug 16, 2023 · 35 comments · Fixed by #6968
Labels
B-bug Bug: general classification S-verified Status: Verified by maintainer

Comments

@JeroenVdb
Copy link
Contributor

Expected Behavior

My keyboard shortcuts/keybinding are not working anymore. For example hitting Command + P does not open the Switch Requests pallet. Command + , does not open the Insomnia settings.

Actual Behavior

Nothing happens.

Reproduction Steps

  1. Press Command + ,
  2. Nothing happens

Is there an existing issue for this?

Additional Information

This worked before. AFAIK it stopped working since I updated to v2023.5.2 this morning.

Insomnia Version

2023.5.2

What operating system are you using?

macOS

Operating System Version

Venture 13.5 (22G74)

Installation method

Downloaded from Insomnia.rest website

Last Known Working Insomnia version

< 2023.5.2 (but don't know specific version, I'm a regular updater so I guess the previous version)

@JeroenVdb JeroenVdb added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels Aug 16, 2023
@jackkav
Copy link
Contributor

jackkav commented Aug 16, 2023

The request switcher was spaghetti code so we dropped it to unblock our refactor, it will be back soon. The settings hotkey works on my machine.

@JeroenVdb
Copy link
Contributor Author

The request switcher was spaghetti code so we dropped it to unblock our refactor, it will be back soon.

Clear, hope it's back soon. I mainly used it to quickly switch between collections. It was the closest to a general Command Pallet in the app.

The settings hotkey works on my machine.

Command + , still does not work on my machine. But Command + Shift + , does work. I'm on an AZERTY keyboard. Maybe that explains it?

@jackkav
Copy link
Contributor

jackkav commented Aug 16, 2023

We are thinking about introducing exactly that kind of command palette idea!

That would certainly explain it.
I'll keep this issue open until switcher is back

@jackkav jackkav changed the title Keyboard shortcuts not working anymore Request switcher keyboard shortcuts not working Aug 16, 2023
@Caskman
Copy link

Caskman commented Aug 17, 2023

This is not a refactor, this is a major version change since features were dropped. Ctrl + Tab is extremely useful when I have a lot of requests and I'm switching between requests on opposite ends of the list.

I know I can switch to a previous version but this makes me much more reluctant to update going forward

@jackkav jackkav added S-verified Status: Verified by maintainer and removed S-unverified Status: Unverified by maintainer labels Aug 17, 2023
@drahnieR
Copy link

This is not a refactor, this is a major version change since features were dropped.

And I'm surprised that it's not mentioned in the changelog.

@johnli2210
Copy link

For anyone looking to rollback I tested each GA release and 2023.4.0 appears to be the last stable version with a working Request Switcher: https://github.com/Kong/insomnia/releases/tag/core%402023.4.0

I for one find this feature essential!

@nikbrunner
Copy link

For anyone looking to rollback I tested each GA release and 2023.4.0 appears to be the last stable version with a working Request Switcher: https://github.com/Kong/insomnia/releases/tag/core%402023.4.0

I for one find this feature essential!

Thank you very much! This is also very essential for me!

Now Cmd+p works again, but what I find interesting is, that now Cmd+Shift+e (This opens the Env Switcher by default) is not working in this version (2023.4.0).

In the current version, it is the other way round.

@sebastianjonasson
Copy link
Contributor

Now Cmd+p works again, but what I find interesting is, that now Cmd+Shift+e (This opens the Env Switcher by default) is not working in this version (2023.4.0).

Cmd+Shift+e was patched in 2023.5.0.

@nikbrunner
Copy link

Now Cmd+p works again, but what I find interesting is, that now Cmd+Shift+e (This opens the Env Switcher by default) is not working in this version (2023.4.0).

Cmd+Shift+e was patched in 2023.5.0.

Yes, I know, but in 2023.5.0 is Cmd+p is not working. 😁

@VerinskiiNikita
Copy link

still not working 2023.5.7
cmd+p

@bukajsytlos
Copy link

this should be top priority...

@nikbrunner
Copy link

Version: 2023.5.8

These for me essential key binds are (still) not working:

  • cmd+p - Browse Requests
  • cmd+shift+e - Switch Environment

@xaviergmail
Copy link

For the longest time, I thought it had something to do with the vim keybinds option, or something wrong with my Karabiner configuration. I'm relieved to know it's not just me.

FWIW, neither cmd+p or cmd+shift+e are working on 8.0.0 (2023-09-27 build)

@relgames
Copy link

relgames commented Oct 1, 2023

Hi, CMD+P is not working for me as well in 8.1.0:

Version: Insomnia 8.1.0
Build date: 9/28/2023

Seems like this issue is open for 1.5 months, can you just bring back the "spaghetti code" which worked and we liked it, and then after the refactoring, feel free to delete it?

@Lasse-BeCause
Copy link

Quickly tabbing between recent requests is super useful to me. I'm considering switching away from Insomnia because of this simple feature, that's how much I use tabbing between requests.

Btw the Preferences menu still has the keybind, so it's not clear to me whether this feature is supposed to work or be gone forever.

@almeidacavalcante
Copy link

I just updated and CMD+P ramains not working. I tried to change the shortcut but didn't have any luck. Do we know any insomnia version that works?

@Ivan-Donchenko
Copy link

Ivan-Donchenko commented Oct 4, 2023

@almeidacavalcante This one works for me https://github.com/Kong/insomnia/releases/tag/core%402023.4.0
It seems its last version with working request switcher

@VerinskiiNikita
Copy link

VerinskiiNikita commented Oct 7, 2023

The request switcher was spaghetti code so we dropped it to unblock our refactor, it will be back soon. The settings hotkey works on my machine.

So sorry that it is October now and shortcuts still not working. So sorry that I have to change platform to postman

@Kong Kong deleted a comment from suchislife801 Oct 9, 2023
@mbcompass
Copy link

Please, bring back cmd+p and control+tab

@nedmules-sked
Copy link

Hi @jackkav and the Insomnia product managers

I have been unable to upgrade Insomnia past version 2023.4.0 because for me it is unusable without the Ctrl-Tab feature to switch between requests - I have 100's of requests in my workspace so scrolling or filtering is not an option. I want to upgrade so I can get bug fixes in later versions.

In August, Jack said:

The request switcher was spaghetti code so we dropped it to unblock our refactor, it will be back soon. The settings hotkey works on my machine.

Can you tell us where the request switcher sits on your list of priorities and when you expect it to be fixed/restored? In my view, you should fix this major breaking change before adding any more features.

Thanks, Ned

@relgames
Copy link

relgames commented Dec 5, 2023

Turned out, 2013.4.0 has another issue - unable to search environments, it just shows a big dropdown but not able to type to filter the dropdown list.

Why do you keep breaking features? Just stop, it was working well and we were paying for it for 10 developers. Now it does not work and no one wants to use it anymore.

@subnetmarco
Copy link
Member

As discussed in #6815 (reply in thread) let's see if we can get this fixed in our December release in a couple of weeks.

@subnetmarco
Copy link
Member

This issue has been fixed and will ship in the next release of Insomnia in late January.

@subnetmarco
Copy link
Member

Available in 8.5.2 beta, before GA (next week) we will also make it work across multiple organizations.

@JeroenVdb
Copy link
Contributor Author

I'm using the beta, works great in general at first sight 💪

One remark: is it possible to already select the first item from the list? Now you have to press down to select/highlight the first item in the list. I watched some other command palettes (Chrome DevTools, Raycast, IntelliJ) and they all have the first item automatically selected.

@subnetmarco
Copy link
Member

@JeroenVdb good feeback, yes we can do that.

@JeroenVdb
Copy link
Contributor Author

JeroenVdb commented Jan 15, 2024

Feedback about the filter being used, leaving it here because the feature is still in beta, but I can also create a new issue if that would be better.

I think the current code for the filter needs some improvements.

The current filter splits the filter query and adds wildcards between each character. Which leads to some weird items not being filtered out because they "accidentally" have those characters in that order somehow.

For example:

Search for "scen"

Returns:
- "GET /scenarios {{ _.ServiceBaseUrl }}/scenarios"
- "GET /changes {{ _.ServiceBaseUrl }}/changes"

I would expect the first one but not the second one.

If I remember correctly the previous search of the request switcher worked very accurate, meaning my searches most of the time narrowed the list down to the item I was looking for or maybe with at most 5 other possibilities showing.

The previous "request-switcher" used the fuzzyMatchAll util function. As this function still exists it might be an easy change again use this way of filtering.

@bukajsytlos
Copy link

afair it worked like that before

@bukajsytlos
Copy link

does this also fix ctrl+tab?

@nikbrunner
Copy link

The default binding for switching Environments or a custom one is still not working. cmd+p works now though.

image

@JeroenVdb
Copy link
Contributor Author

I think it’s best to create a new issue for this.

Also: I would rather add this functionality to the command palette instead of a separate modal. The shortcut could then open the command palette with a predefined filter. See #7030

@vytautasphp
Copy link

New version updated, but ctrl+tab still not working... unbelievable, Insomnia now has a lot of useless features, but super simple feature not working, wtf... Its so annoying...

@JeroenVdb
Copy link
Contributor Author

@vytautasphp it might be a good idea to open a new issue, this one was very focused on switching between requests and collections. I think your issue is more about switching between the last X requests made.

@bukajsytlos
Copy link

sry, but this issue was mentioned here x times. if they did not want to implement it here, then they should made new issue...

@subnetmarco
Copy link
Member

subnetmarco commented Feb 10, 2024

We re-introduced CMD + P. We will work on fixing CMD + SHIFT + E and CTRL+TAB, most likely it will ship in the next release.

I am tasking the team to go over the entire list of all shortcuts to check them all, as a matter of fact.

Apologies for the disruption, all these issues are getting improved on every release, we are doing our best to keep up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification S-verified Status: Verified by maintainer
Projects
None yet