Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt tag prompts for input twice #6387

Closed
1 task done
ArcanoxDragon opened this issue Aug 24, 2023 · 26 comments
Closed
1 task done

Prompt tag prompts for input twice #6387

ArcanoxDragon opened this issue Aug 24, 2023 · 26 comments
Labels
B-bug Bug: general classification S-verified Status: Verified by maintainer

Comments

@ArcanoxDragon
Copy link

Expected Behavior

When a request has a single "Prompt" tag in the URL (and nowhere else in the request), it should only prompt for input once.

Actual Behavior

A prompt appears for the same prompt tag twice in a row. The value from the first prompt is used in the request, but the value for the second prompt is stored as the "previous value".

If the first prompt is canceled, a dialog box shows up indicating the request failed:
image

If the second prompt is canceled, the app crashes:
image

Reproduction Steps

  1. Create a request
  2. Somewhere in the URL, add a single Prompt tag
  • In my request, the "Title", "Label", and "Default Value" settings are configured, and "Storage Key" is blank. "Mask Text" is disabled, and "Default to Last Value" is enabled.
  1. Send the request
  2. Observe that the prompt dialog appears twice

Is there an existing issue for this?

Additional Information

No response

Insomnia Version

2023.5.6

What operating system are you using?

Windows

Operating System Version

Windows 10 22H2, build 19045

Installation method

Downloaded via website and updated recently using automatic updater

Last Known Working Insomnia version

No response

@ArcanoxDragon ArcanoxDragon added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels Aug 24, 2023
@kressnick25
Copy link

I am also getting this issue.

@Tobbe3108
Copy link

Same here

@jmkraut
Copy link

jmkraut commented Aug 27, 2023

I'm getting this issue as well.

@Bastelbaer
Copy link

Same here

@PatoGordo
Copy link

Same using MacOS

@Ob1Ju4n
Copy link

Ob1Ju4n commented Aug 30, 2023

Same issue using macOS 13.5.1

@db-geek
Copy link

db-geek commented Aug 31, 2023

I also can confirm this issue with following Insomnia Versions on Linux:

  • 2023.5.5
  • 2023.5.6
  • 2023.5.7

@Doable149
Copy link

Same for me

@synthead
Copy link

synthead commented Sep 8, 2023

Also seeing this with 2023.5.8 👌

@smmcneill
Copy link

Same

@darkshadow444
Copy link

Same issue for 2023.5.8, 2023.5.7, 2023.5.6, 2023.5.5

@kalimbra
Copy link

kalimbra commented Sep 21, 2023

Same here for linux, insomnia 2023.5.8

Version: Insomnia 2023.5.8
Build date: 07/09/2023
OS: Linux x64 5.3.0-28-generic
Electron: 25.2.0
Node: 18.15.0
Node ABI: 116
V8: 11.4.183.23-electron.0
Architecture: x64

@mdemille
Copy link

Still an issue on Mac after upgrade to 8.0.0

Version: Insomnia 8.0.0
Build date: 9/27/2023
OS: Darwin arm64 22.6.0
Electron: 25.8.1
Node: 18.15.0
Node ABI: 116
V8: 11.4.183.29-electron.0
Architecture: arm64

@thenoseman
Copy link

thenoseman commented Oct 1, 2023

Just found out that the prompt works as expected (shown once) when you use a manually entered "Storage Key".
Potentially this is the place to look:

const titleHash = crypto
.createHash('md5')
.update(title)
.digest('hex');
const storageKey = explicitStorageKey || `${context.meta.requestId}.${titleHash}`;
const cachedValue = await context.store.getItem(storageKey);

@mcianc
Copy link

mcianc commented Oct 8, 2023

same problem
Linux Ubuntu 22.10
Version: Insomnia 8.2.0

@pas-sean
Copy link

pas-sean commented Oct 13, 2023

Same problem on a Mac
Version: Insomnia 8.2.0
Build date: 10/4/2023
OS: Darwin arm64 23.0.0
Electron: 25.8.1
Node: 18.15.0
Node ABI: 116
V8: 11.4.183.29-electron.0
Architecture: arm64

@filfreire filfreire added S-verified Status: Verified by maintainer and removed S-unverified Status: Unverified by maintainer labels Oct 16, 2023
@aafaque33
Copy link

aafaque33 commented Nov 6, 2023

Same issue getting in v8.x, 2023.5.8, 2023.5.7, 2023.5.6, 2023.5.5, 2023.5.4
OS Mac 12.7.1

@yabols
Copy link

yabols commented Nov 9, 2023

Same for me 8.30 version, build 10/13/2023.

@ihexxa
Copy link
Contributor

ihexxa commented Nov 15, 2023

Please keep patience, one fix is wip: #6763

@subnetmarco
Copy link
Member

This has been fixed in 8.4.4, available for download today.

@aafaque33
Copy link

This has been fixed in 8.4.4, available for download today.

Is there a possibility for the fix in old versions like 2023.5.8 ? (Don't want to upgrade to 8.x because of the cloud sync restrictions and also having multiple workspaces which are not available in the Local ScratchPad

@subnetmarco
Copy link
Member

Just so you know, you can still use 8.x with local storage. We reverted back the mandatory cloud sync and from v8.3 onwards you can choose local, cloud or git storage.

@aafaque33
Copy link

Just so you know, you can still use 8.x with local storage. We reverted back the mandatory cloud sync and from v8.3 onwards you can choose local, cloud or git storage.

I agree that v8.3 onwards provide the local capability too, but as compared to old versions it is useless as it provides one collection / workspace, while in old versions most people have multiple collection for different API / Projects and each collection has multiple environments. Now everything is merged into one which is kind of not Insomnia famous for.\

Unless multiple collection is provided in local scratch pad version of 8.3 onwards in the future .

@subnetmarco
Copy link
Member

You can have multiple local collections/projects after logging in for free.

Without logging in you can still use the Scratch Pad which - as you noted - is limited to one collection only.

@ArcanoxDragon
Copy link
Author

Really frustrating that the fix is only included in a version that requires signing into an account to be useful. I've got probably a dozen collections I need to use, and I really don't want to sign into a cloud service just to use locally-stored collections in a desktop app.

I'll just have to deal with the bug until I have the time to find a new local-only REST client and convert all my collections...

@aafaque33
Copy link

aafaque33 commented Mar 21, 2024

Really frustrating that the fix is only included in a version that requires signing into an account to be useful. I've got probably a dozen collections I need to use, and I really don't want to sign into a cloud service just to use locally-stored collections in a desktop app.

I'll just have to deal with the bug until I have the time to find a new local-only REST client and convert all my collections...

https://github.com/ArchGPT/insomnium is the replacement I have found so you may want to look into this too. This is the older forked version of insomnia with bug fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification S-verified Status: Verified by maintainer
Projects
None yet
Development

No branches or pull requests