Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected partial matches when filtering for requests #6494

Open
1 task done
brendanm-stripe opened this issue Sep 13, 2023 · 3 comments · Fixed by #6640
Open
1 task done

Unexpected partial matches when filtering for requests #6494

brendanm-stripe opened this issue Sep 13, 2023 · 3 comments · Fixed by #6640
Labels
B-bug Bug: general classification E-good-first-issue Experience required: Beginner / New S-verified Status: Verified by maintainer

Comments

@brendanm-stripe
Copy link

brendanm-stripe commented Sep 13, 2023

Expected Behavior

When entering multiple words in the sidebar request filter, I expect the filtered result set to only include requests which match all words in filter. This was the existing behaviour recently and make it easy to filter large lists of requests by describing details in the name.

Actual Behavior

When multiple words are entered in the filter, requests are returned if they match any of the words in the filter.

This makes it difficult to filter large request lists by attributes described in the request name/label as was previously possible.

Reproduction Steps

1/ Create three requests with names:
fizz
buzz
fizz buzz

2/ Enter filter term: fizz buzz

3/ Look at filtered results.

Expect only request "fizz buzz" (matches both words in filter) but get all three instead.

Is there an existing issue for this?

Additional Information

I suspect this may be related to the use of fuzzyMatchAll in #6323

Insomnia-filtering

Insomnia Version

2023.5.8

What operating system are you using?

macOS

Operating System Version

macOS Ventura 13.5.2

Installation method

download from insomnia.rest, auto updated

Last Known Working Insomnia version

unknown but believe < 2023.5.0

@brendanm-stripe brendanm-stripe added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels Sep 13, 2023
@filfreire
Copy link
Member

@brendanm-stripe thanks for reporting this, we can also reproduce

image

@filfreire filfreire added E-good-first-issue Experience required: Beginner / New S-verified Status: Verified by maintainer and removed S-unverified Status: Unverified by maintainer labels Sep 27, 2023
@filfreire filfreire changed the title Regression in request filtering behaviour - getting unexpected partial matches Unexpected partial matches when filtering for requests Sep 27, 2023
@brendanm-stripe
Copy link
Author

brendanm-stripe commented Sep 27, 2023

I have since discovered, accidentally, that I can kind of work around this by omitting spaces in my filter terms. The catch here is that the terms need to be in the correct order matching the request name:

fizz-buzz-all fizz-buzz-2

This is also a bit off because I would not actually expect either request to match in the above without a space, but allows me to mostly keep going.

@jayant-vashisth
Copy link

is this open or anyone working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: general classification E-good-first-issue Experience required: Beginner / New S-verified Status: Verified by maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants