Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] UI should show matches when filtering requests by folder, URI, method, query string #857

Closed
shawnaxsom opened this issue Apr 9, 2018 · 6 comments
Labels
stale Bot: Stale Issue

Comments

@shawnaxsom
Copy link
Contributor

  • Insomnia Version: Version 1.7.9 (1.7.9)
  • Operating System: Version 10.13.3 (17D47) - macOS High Sierra

Details

I previously implemented the business logic for searching by folder, URI, method, and query string in #797 as a fix for #739. This has been merged.

This is a follow up to that, to show in the UI what field and value has been matched. This needs to apply to the Quick Switch window, possibly as well as the filter in the sidebar.

For Quick Switch, we can consider libraries like fuzzy or fuzzysearch, like @roblav96 recommended. We will likely need to make the search results show at least 2 rows, to be able to fit the matching text, otherwise matches on e.g. long URLs won't fit as easily at smaller widths.

@welcome
Copy link

welcome bot commented Apr 9, 2018

👋 Thanks for opening your first issue! If you're reporting a 🐞 bug, please make sure
you include steps to reproduce it. If you're requesting a feature 🎁, please provide real
use cases that would benefit. 👪

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@shawnaxsom
Copy link
Contributor Author

shawnaxsom commented Apr 15, 2018

@gschier Here is what I have so far. What do you think? It is essentially working for the Quick Switch window.

Do you think I should apply the pattern matching to the sidebar as well? If so, should we even worry about URL in the sidebar, given it is too long to realistically show?

Screenshot: https://cl.ly/0p1i2c2e3N18
GIF: https://cl.ly/011H001a2J3k

@gschier
Copy link
Contributor

gschier commented Apr 15, 2018

Woah, I'm really liking that @axs221. You want to put up a PR soon so we can finalize it?

@shawnaxsom
Copy link
Contributor Author

@gschier Sure thing, here is a PR: #864.

It is a work in progress (see section What is left to do or discuss?), but it is usable. Feel free to review/comment if you want.

@gschier gschier changed the title UI should show matches when filtering requests by folder, URI, method, query string [Improvement] UI should show matches when filtering requests by folder, URI, method, query string Apr 20, 2018
@stale
Copy link

stale bot commented Jun 19, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Bot: Stale Issue label Jun 19, 2018
@gschier
Copy link
Contributor

gschier commented Jun 19, 2018

Oh, this was done a while ago!

@gschier gschier closed this as completed Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Bot: Stale Issue
Projects
None yet
Development

No branches or pull requests

2 participants