-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] UI should show matches when filtering requests by folder, URI, method, query string #857
Comments
👋 Thanks for opening your first issue! If you're reporting a 🐞 bug, please make sure To help make this a smooth process, please be sure you have first read the |
@gschier Here is what I have so far. What do you think? It is essentially working for the Quick Switch window. Do you think I should apply the pattern matching to the sidebar as well? If so, should we even worry about URL in the sidebar, given it is too long to realistically show? Screenshot: https://cl.ly/0p1i2c2e3N18 |
Woah, I'm really liking that @axs221. You want to put up a PR soon so we can finalize it? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Oh, this was done a while ago! |
Details
I previously implemented the business logic for searching by folder, URI, method, and query string in #797 as a fix for #739. This has been merged.
This is a follow up to that, to show in the UI what field and value has been matched. This needs to apply to the Quick Switch window, possibly as well as the filter in the sidebar.
For Quick Switch, we can consider libraries like fuzzy or fuzzysearch, like @roblav96 recommended. We will likely need to make the search results show at least 2 rows, to be able to fit the matching text, otherwise matches on e.g. long URLs won't fit as easily at smaller widths.
The text was updated successfully, but these errors were encountered: