Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdk) plugin closure syntax correction #64

Merged
merged 1 commit into from Jun 12, 2022

Conversation

wjziv
Copy link
Contributor

@wjziv wjziv commented May 24, 2022

fix #28

Drafted using the new-instance method as a template.
Tested in a sample instance of kong.

I don't see any unit testing in this library; have I missed it somehow?

@CLAassistant
Copy link

CLAassistant commented May 24, 2022

CLA assistant check
All committers have signed the CLA.

@fffonion
Copy link
Collaborator

@wjziv Tests for python PDK are planned work but not yet prioritized, PRs are welcomed in the meanwhile!

@fffonion fffonion merged commit 920cc26 into Kong:master Jun 12, 2022
@fffonion
Copy link
Collaborator

Thank you @wjziv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old instances of plugin not getting deleted
3 participants