Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): http/stream subsystem does not share schema #11914

Merged
merged 16 commits into from Nov 8, 2023
Merged

refactor(router): http/stream subsystem does not share schema #11914

merged 16 commits into from Nov 8, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 3, 2023 •
edited

Summary

We do not need the function has_paths(), which is only useful for http subsystem, and now we support expressions in both http and stream subsystem.

KAG-2961

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 3, 2023
@chronolaw chronolaw marked this pull request as ready for review November 3, 2023 08:23
@chobits chobits force-pushed the refactor/http_stream_does_not_share_schema branch from a1fad05 to c9e7146 Compare November 3, 2023 08:29
@chronolaw chronolaw force-pushed the refactor/http_stream_does_not_share_schema branch from c9e7146 to 8768266 Compare November 3, 2023 08:41
@chronolaw chronolaw requested a review from dndx November 6, 2023 03:13
tzssangglass
tzssangglass reviewed Nov 6, 2023
View reviewed changes
kong/router/atc.lua Outdated Show resolved Hide resolved
@dndx
Copy link
Member

dndx commented Nov 7, 2023

Does the cache key calculation algorithm needs to be updated in this PR before it merges? Would it cause cache bugs if merged as-is right now?

@chronolaw
Copy link
Contributor Author

chronolaw commented Nov 7, 2023 •
edited

Does the cache key calculation algorithm needs to be updated in this PR before it merges? Would it cause cache bugs if merged as-is right now?

No, It will be OK because we did not change the cache hash algorithm, now schema has no relationship with cache calculation.

We will change the algorithm in the next PR.

@locao locao requested a review from gszr November 7, 2023 17:46
@chronolaw
Copy link
Contributor Author

@locao @gszr, Just a clarification, the schema in this PR is the router's own schema, it has no relationship with kong db schema.

@dndx
Copy link
Member

dndx commented Nov 8, 2023

@chronolaw This PR needs a changelog entry. It should be listed as "bugfix".

@dndx dndx force-pushed the refactor/http_stream_does_not_share_schema branch from 32273e3 to ad38a9d Compare November 8, 2023 06:37
@dndx dndx merged commit 37bd9c2 into master Nov 8, 2023
24 checks passed
@dndx dndx deleted the refactor/http_stream_does_not_share_schema branch November 8, 2023 07:27
chronolaw added a commit that referenced this pull request Jan 23, 2024
@chronolaw @dndx
fix(router): http and stream subsystems no longer share the expre…
d2c0f6b 
…ssions router schema (#11914)

KAG-2961

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
@chronolaw chronolaw mentioned this pull request Jan 23, 2024
Merged
3 tasks
@chronolaw chronolaw mentioned this pull request Jan 23, 2024
Merged
3 tasks
chronolaw added a commit that referenced this pull request Jan 24, 2024
@chronolaw @dndx
fix(router): http and stream subsystems no longer share the expre…
608c25c 
…ssions router schema (#11914)

KAG-2961

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
chronolaw added a commit that referenced this pull request Feb 26, 2024
@chronolaw @dndx
fix(router): http and stream subsystems no longer share the expre…
4de5242 
…ssions router schema (#11914)

KAG-2961

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
chronolaw added a commit that referenced this pull request Feb 26, 2024
@chronolaw @dndx
fix(router): http and stream subsystems no longer share the expre…
4fc4ba3 
…ssions router schema (#11914)

KAG-2961

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
chronolaw added a commit that referenced this pull request Mar 4, 2024
@chronolaw @dndx
fix(router): http and stream subsystems no longer share the expre…
dc727d4 
…ssions router schema (#11914)

KAG-2961

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
locao pushed a commit that referenced this pull request Mar 5, 2024
@chronolaw @dndx @locao
fix(router): http and stream subsystems no longer share the expre…
53e96a1 
…ssions router schema (#11914)

KAG-2961

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
ADD-SP pushed a commit that referenced this pull request Mar 7, 2024
@chronolaw @dndx @ADD-SP
fix(router): http and stream subsystems no longer share the expre…
673979f 
…ssions router schema (#11914)

KAG-2961

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
ADD-SP pushed a commit that referenced this pull request Mar 7, 2024
@chronolaw @dndx @ADD-SP
fix(router): http and stream subsystems no longer share the expre…
fead4d2 
…ssions router schema (#11914)

KAG-2961

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dndx dndx dndx approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@gszr gszr Awaiting requested review from gszr

Assignees

@chronolaw chronolaw

Labels
core/db schema-change-noteworthy size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chronolaw @dndx @tzssangglass