New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cp): add dp cert details #11921

Merged

flrgh merged 15 commits into Kong:master from tzssangglass:expose_cert_expiry_to_api

Nov 16, 2023

Member

tzssangglass commented Nov 6, 2023 •

edited

Summary

support for exposing dataplane certificate expiry date to /clustering/data-planes endpoint

Checklist

The Pull Request has tests
A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

Issue reference


          feat(cp): add dp cert details

a929eb0

support for exposing dataplane certificate expiry date to
`/clustering/data-planes` endpoint

Fix: [FTI-5530](https://konghq.atlassian.net/browse/FTI-5530)
Signed-off-by: tzssangglass <tzssangglass@gmail.com>

pull-request-size bot added the size/L label

github-actions bot added core/db/migrations core/clustering core/db schema-change-noteworthy labels

tzssangglass added 5 commits

November 6, 2023 15:54


          add changelog

1f31244

Signed-off-by: tzssangglass <tzssangglass@gmail.com>


          add migration script to rockspec

b184c79

Signed-off-by: tzssangglass <tzssangglass@gmail.com>


          Merge branch 'master' into expose_cert_expiry_to_api

c10b28e

Signed-off-by: tzssangglass <tzssangglass@gmail.com>


          fix typo

b236139

Signed-off-by: tzssangglass <tzssangglass@gmail.com>


          Merge branch 'master' into expose_cert_expiry_to_api

3c73bf3

Signed-off-by: tzssangglass <tzssangglass@gmail.com>

tzssangglass marked this pull request as ready for review

November 7, 2023 05:46

tzssangglass requested review from flrgh and gruceo

November 7, 2023 05:46

flrgh reviewed

View reviewed changes

spec/02-integration/09-hybrid_mode/01-sync_spec.lua Outdated Show resolved Hide resolved

flrgh reviewed

View reviewed changes

kong/clustering/tls.lua Outdated Show resolved Hide resolved


          apply comments

32bc411

Signed-off-by: tzssangglass <tzssangglass@gmail.com>

flrgh reviewed

View reviewed changes

kong/clustering/control_plane.lua Outdated Show resolved Hide resolved

dndx previously requested changes

View reviewed changes

kong/clustering/tls.lua Outdated Show resolved Hide resolved

tzssangglass added 2 commits

November 9, 2023 14:56


          apply comments

beefe2c

Signed-off-by: tzssangglass <tzssangglass@gmail.com>


          chore

Signed-off-by: tzssangglass <tzssangglass@gmail.com>

gruceo reviewed

View reviewed changes

spec/01-unit/01-db/01-schema/13-cluster_status_spec.lua Outdated Show resolved Hide resolved

kong/db/schema/entities/clustering_data_planes.lua Outdated Show resolved Hide resolved

kong/clustering/control_plane.lua Show resolved Hide resolved


          apply coments

4c037d6

Signed-off-by: tzssangglass <tzssangglass@gmail.com>

tzssangglass requested review from flrgh, dndx and gruceo

November 10, 2023 02:41

ms2008 reviewed

View reviewed changes

Contributor

ms2008 left a comment

Just one more nit, so feel free to ignore. 😄

kong/clustering/tls.lua Outdated Show resolved Hide resolved


          apply comments

2c4b4e5

tzssangglass requested a review from ms2008

November 13, 2023 08:41

flrgh reviewed

View reviewed changes

kong/clustering/control_plane.lua Outdated Show resolved Hide resolved

flrgh reviewed

View reviewed changes

kong/db/schema/entities/clustering_data_planes.lua Outdated Show resolved Hide resolved

tzssangglass added 2 commits

November 15, 2023 09:56


          apply comments

41b262c

Signed-off-by: tzssangglass <tzssangglass@gmail.com>


          Merge branch 'master' into expose_cert_expiry_to_api

39d2380

tzssangglass requested a review from flrgh

November 15, 2023 09:15

flrgh reviewed

View reviewed changes

kong/clustering/tls.lua Show resolved Hide resolved

flrgh reviewed

View reviewed changes

spec/02-integration/03-db/13-cluster_status_spec.lua Outdated Show resolved Hide resolved

flrgh approved these changes

View reviewed changes

Contributor

flrgh left a comment

Looks good! I've left a couple recommendations for things that can be tidied up before merge.


          formatting

2e8e1f9

Signed-off-by: tzssangglass <tzssangglass@gmail.com>

ms2008 approved these changes

View reviewed changes

windmgc approved these changes

View reviewed changes

windmgc reviewed

View reviewed changes

changelog/unreleased/kong/cp-expose-dp-cert-details.yml Outdated Show resolved Hide resolved

oowl approved these changes

View reviewed changes


          update changelog

214bfa0

Signed-off-by: tzssangglass <tzssangglass@gmail.com>

flrgh dismissed dndx’s stale review

November 16, 2023 17:55

requested changes were made

flrgh merged commit a382576 into Kong:master

25 checks passed

lena-larionova mentioned this pull request

Feat: Add cert expiry to clustering/data-planes output Kong/docs.konghq.com#6938

Merged

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

windmgc windmgc approved these changes

flrgh flrgh approved these changes

ms2008 ms2008 approved these changes

oowl oowl approved these changes

dndx Awaiting requested review from dndx

gruceo Awaiting requested review from gruceo