Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdk): response send function should ignore transfer-encoding correctly #11936

Merged
merged 4 commits into from Nov 8, 2023

Conversation

windmgc
Copy link
Contributor

@windmgc windmgc commented Nov 7, 2023

Summary

This PR is a follow-up fix for #8698 to ignore the transfer encoding header set by the user.

The line removed in this PR seems to be conflict with the original fix and makes the original fix meaningless, so removed this line to get the expected behavior.

We have related bug reports that when using the AWS-Lambda plugin in proxy_integration mode if the lamdba function returns an arbitrary transfer-encoding header, the response sent by Kong will both contain content-length and transfer-encoding, which is an unexpected result.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [na] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix FTI-5028

@windmgc windmgc merged commit 444b214 into master Nov 8, 2023
24 checks passed
@windmgc windmgc deleted the fix-response-exit-remove-transfer-encoding branch November 8, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants