plugin(datadog): fix a bug that datalog plugin is not triggered for serviceless routes #12068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liverpool8056
force-pushed
the
fix/serverless-routes-still-trigger-datalog-plugin
branch
from
5d56179
to
8888d67
Compare
liverpool8056
force-pushed
the
fix/serverless-routes-still-trigger-datalog-plugin
branch
from
50687f3
to
91a485a
Compare
liverpool8056
changed the title
liverpool8056
force-pushed
the
fix/serverless-routes-still-trigger-datalog-plugin
branch
from
91a485a
to
2081925
Compare
serviceless routes are hit. FTI-5576
liverpool8056
force-pushed
the
fix/serverless-routes-still-trigger-datalog-plugin
branch
from
2081925
to
c167c3e
Compare
liverpool8056
force-pushed
the
fix/serverless-routes-still-trigger-datalog-plugin
branch
from
dee259d
to
5dd913b
Compare
oowl
approved these changes
Nov 23, 2023
windmgc
approved these changes
Nov 23, 2023
windmgc
deleted the
fix/serverless-routes-still-trigger-datalog-plugin
branch
liverpool8056
added
the
cherry-pick kong-ee
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix a bug that datadog plugin is not triggered for serviceless routes.
In this PR, the datadog plugin can be triggered even if the serviceless routes are hit, and the value of tag
namefor the metric data is set to an empty string which is still a valid tag for datadog.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
Issue reference
FTI-5576