Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dbless): fix error data loss caused by weakly typed of function in declarative_config_flattened function #12167

Merged
merged 8 commits into from Dec 19, 2023
Merged

fix(dbless): fix error data loss caused by weakly typed of function in declarative_config_flattened function #12167

merged 8 commits into from Dec 19, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Dec 7, 2023 •
edited

Summary

fix error data loss caused by weakly typed of function in declarative_config_flattened function

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

FTI-5584

@oowl oowl changed the title fix(dbless): fix error data loss caused by shallow copying of a table in declarative_config_flattened function fix(dbless): fix error data loss caused by weakly typed of function in declarative_config_flattened function Dec 12, 2023
@oowl oowl requested a review from flrgh December 12, 2023 07:53
@oowl oowl requested a review from flrgh December 18, 2023 06:32
@programmer04 programmer04 mentioned this pull request Dec 18, 2023
Closed
2 tasks
flrgh
flrgh approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@flrgh flrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left one suggestion to make the test case slightly more consistent with the others, but it's not a blocker.

@windmgc windmgc merged commit 410d9bd into master Dec 19, 2023
27 checks passed
@windmgc windmgc deleted the fix/flattened_errors branch December 19, 2023 03:13
github-actions bot pushed a commit that referenced this pull request Jan 18, 2024
@oowl @github-actions
fix(dbless): fix error data loss caused by weakly typed of function i…
62925f3 
…n declarative_config_flattened function (#12167)

FTI-5584

(cherry picked from commit 410d9bd)
@team-gateway-bot team-gateway-bot mentioned this pull request Jan 18, 2024
Merged
@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.4.x:

bungle pushed a commit that referenced this pull request Jan 18, 2024
@oowl @bungle
fix(dbless): fix error data loss caused by weakly typed of function i…
35c79dd 
…n declarative_config_flattened function (#12167)

FTI-5584

(cherry picked from commit 410d9bd)
@kikito kikito mentioned this pull request Jan 24, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainest rainest rainest left review comments

@mflendrich mflendrich mflendrich left review comments

@czeslavo czeslavo czeslavo left review comments

@programmer04 programmer04 programmer04 left review comments

@flrgh flrgh flrgh approved these changes

@outsinre outsinre outsinre approved these changes

Assignees

@oowl oowl

Labels
backport release/3.4.x core/db size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@oowl @team-gateway-bot @rainest @mflendrich @flrgh @outsinre @czeslavo @programmer04 @windmgc