Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(timer-ng): bump the minimum/maximum threads #12275

Merged
merged 2 commits into from Jan 19, 2024

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Jan 2, 2024

Please REBASE AND MERGE

Summary

Changes for timer-ng.

We need to add default concurrency limits to handle some cases where timed tasks proliferate.

Checklist

  • [N/A] The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-2932, KAG-3452

@ADD-SP ADD-SP force-pushed the add_sp/perf-bump-cocurrency-of-timer-ng branch 2 times, most recently from bb777bc to ce02927 Compare January 2, 2024 09:59
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Jan 3, 2024
@ADD-SP ADD-SP force-pushed the add_sp/perf-bump-cocurrency-of-timer-ng branch 2 times, most recently from a77391f to 918c433 Compare January 3, 2024 02:13
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 3, 2024
@ADD-SP ADD-SP force-pushed the add_sp/perf-bump-cocurrency-of-timer-ng branch 12 times, most recently from f77fca6 to 260bf01 Compare January 3, 2024 09:45
@ADD-SP ADD-SP marked this pull request as ready for review January 4, 2024 02:00
@ADD-SP ADD-SP marked this pull request as draft January 4, 2024 02:00
@ADD-SP ADD-SP marked this pull request as ready for review January 4, 2024 05:21
@ADD-SP ADD-SP added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 9, 2024
@ADD-SP ADD-SP marked this pull request as draft January 9, 2024 05:47
@ADD-SP ADD-SP force-pushed the add_sp/perf-bump-cocurrency-of-timer-ng branch 4 times, most recently from 60bd188 to 2da1e6c Compare January 10, 2024 08:40
@ADD-SP ADD-SP force-pushed the add_sp/perf-bump-cocurrency-of-timer-ng branch 2 times, most recently from 511f507 to 3f42575 Compare January 11, 2024 02:12
@ADD-SP ADD-SP marked this pull request as ready for review January 11, 2024 03:12
@ADD-SP
Copy link
Contributor Author

ADD-SP commented Jan 11, 2024

The internal performance test has passed.

.github/workflows/build_and_test.yml Outdated Show resolved Hide resolved
changelog/unreleased/kong/bump-cocurrency-of-timer-ng.yml Outdated Show resolved Hide resolved
kong/init.lua Show resolved Hide resolved
@ADD-SP ADD-SP force-pushed the add_sp/perf-bump-cocurrency-of-timer-ng branch 5 times, most recently from ed5908d to d0ca663 Compare January 15, 2024 06:54
@ADD-SP ADD-SP added this to the 3.6.0 milestone Jan 19, 2024
@ADD-SP ADD-SP force-pushed the add_sp/perf-bump-cocurrency-of-timer-ng branch from c1b286c to e5ceb4a Compare January 19, 2024 06:54
@ADD-SP ADD-SP force-pushed the add_sp/perf-bump-cocurrency-of-timer-ng branch from e5ceb4a to 3f618c8 Compare January 19, 2024 06:55
@dndx dndx merged commit f0ba930 into master Jan 19, 2024
23 checks passed
@dndx dndx deleted the add_sp/perf-bump-cocurrency-of-timer-ng branch January 19, 2024 07:38
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12275-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12275-to-master-to-upstream
git checkout -b cherry-pick-12275-to-master-to-upstream
ancref=$(git merge-base 9305665e89f8c83b24c9c3943e83ffaa46b7cb2e 3f618c8ae4f5185ca686dc61a930091936ff25c3)
git cherry-pick -x $ancref..3f618c8ae4f5185ca686dc61a930091936ff25c3

@AndyZhang0707
Copy link
Collaborator

@ADD-SP, Please help and take care of the cherry-pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants