Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix an issue where Kong do not handle properly when Python and Javascript plugin server crashes #12582

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix(core): fix an issue where Kong do not handle properly when Python and Javascript plugin server crashes #12582

merged 1 commit into from
Feb 20, 2024

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Feb 19, 2024 •
edited
Loading

Summary

The bug was introduced when refactoring/cherry-picking. We missed the mp_rpc.lua. The PR also syncs the changes made to EE branches.

DO NOT CHEERY-PICK THIS TO EE.

Checklist

  • [N/A] The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #12364
Fix KAG-3765

@StarlightIbuki StarlightIbuki mentioned this pull request Feb 19, 2024
Closed
1 task
gszr
gszr approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@gszr gszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I have the same changes over here in my wip branch: 55586c1. Let's merge this one and I will rebase mine 👍🏻

@StarlightIbuki @gszr
fix(core): fix an issue where Kong do not handle properly when Python…
3fa6c98 
… and Javascript plugin server crashes

The bug was introduced when refactoring/cherry-picking.

Fix #12364

Co-authored-by: Guilherme Salazar <gsz@acm.org>
@gszr gszr merged commit 069da05 into master Feb 20, 2024
28 checks passed
@gszr gszr deleted the fix/plugin_server branch February 20, 2024 12:53
@gszr
Copy link
Member

gszr commented Feb 20, 2024 •
edited
Loading

@StarlightIbuki - please open the remaining PRs on the kong-ee side, fixing the log line divergence. Also consider fixing this one 55586c1#diff-898289fc808a047bf9f9401e7e7b38625131477da1363ce4f68719a3dd9d6dec

@StarlightIbuki
Copy link
Contributor Author

@StarlightIbuki - please open the remaining PRs on the kong-ee side, fixing the log line divergence. Also consider fixing this one 55586c1#diff-898289fc808a047bf9f9401e7e7b38625131477da1363ce4f68719a3dd9d6dec

Do we have a PR for this branch? Or is it still WIP?

@gszr
Copy link
Member

gszr commented Feb 23, 2024

@StarlightIbuki - please open the remaining PRs on the kong-ee side, fixing the log line divergence. Also consider fixing this one 55586c1#diff-898289fc808a047bf9f9401e7e7b38625131477da1363ce4f68719a3dd9d6dec

Do we have a PR for this branch? Or is it still WIP?

Still wip. I will rebase it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gszr gszr gszr approved these changes

@ms2008 ms2008 ms2008 approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

@StarlightIbuki StarlightIbuki

Labels
core/language/go core/language/js core/language/python size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

100% CPU usage and keep posting event 'reset_instances' to go plugin server
4 participants
@StarlightIbuki @gszr @ms2008 @ADD-SP