Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting luasocket version dependencies in source build #1761

Closed
rowanthorpe opened this issue Oct 23, 2016 · 4 comments
Closed

Conflicting luasocket version dependencies in source build #1761

rowanthorpe opened this issue Oct 23, 2016 · 4 comments
Labels
task/code quality Suggestions that would improve the code quality (e.g. refactors)
Milestone

Comments

@rowanthorpe
Copy link

Summary

When building kong 0.9.3-0 from source, the installation of kong with luarocks has a conflicting dependency:

  • kong == 0.9.3-0 depends on lua-cassandra == 0.5.3 (using 0.5.3-0)
  • lua-cassandra == 0.5.3-0 depends on luasocket ~> 3.0-rc1 (using 3.0rc1-2)
  • kong == 0.9.3-0 depends on luasocket == 2.0.2 (using 3.0rc1-2)

This causes luasocket to be rebuilt 3 times (flip-flopping versions between 2.0.2-6 and 3.0-rc1-2) and for the kong install to finally throw a warning at the end about the unsatisfied luasocket dependency.

Steps To Reproduce

  1. luarocks install kong 0.9.3-0
  2. read the logs

Additional Details & Logs

  • Kong version (0.9.3-0)
  • Debian Jessie (GNU/Linux)
@thibaultcha
Copy link
Member

thibaultcha commented Oct 23, 2016

Hi,

Thanks for reporting. This shouldn't be an issue as LuaSocket 3.0 is mainly about Lua 5.2 and IPv6 support. Besides, Kong only uses the socket.url module while lua-cassandra and pgmoon rely on LuaSockets themselves.

This should also be resolved in 0.10 anyways because lua-cassandra 1.x does not explicitly depend on LuaSocket anymore.

@rowanthorpe
Copy link
Author

OK, thanks for clarifying. If your confidence in the "shouldn't be an issue" factor is high enough (probably yes) then feel free to close this. I'll leave it to your judgement in case you want the issue open as a reminder to check after the bump to 0.10

@thibaultcha
Copy link
Member

Yes, we'll still leave it open until 0.10 is released since we'd rather avoid having bloated dependencies regardless of whether they create issues or not anyways.

Thanks!

@thibaultcha thibaultcha added the task/code quality Suggestions that would improve the code quality (e.g. refactors) label Oct 23, 2016
@thibaultcha thibaultcha added this to the 0.10 RC milestone Oct 23, 2016
@thibaultcha
Copy link
Member

The luasocket dependency is now gone from lua-cassandra 1.x. Closing this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task/code quality Suggestions that would improve the code quality (e.g. refactors)
Projects
None yet
Development

No branches or pull requests

2 participants