Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics) add Grafana dashboard #2035

Merged
merged 2 commits into from Jan 3, 2022
Merged

feat(metrics) add Grafana dashboard #2035

merged 2 commits into from Jan 3, 2022

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Nov 24, 2021

What this PR does / why we need it:
Adds a Grafana dashboard.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1926

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@rainest rainest temporarily deployed to Configure ci November 24, 2021 21:08 Inactive
@rainest rainest temporarily deployed to Configure ci December 10, 2021 18:53 Inactive
@rainest rainest marked this pull request as ready for review December 10, 2021 18:53
@rainest rainest requested a review from a team as a code owner December 10, 2021 18:53
@rainest rainest temporarily deployed to Configure ci December 10, 2021 19:07 Inactive
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally OK with this, but it did sound like @scseanchow might want to take a look.

@rainest
Copy link
Contributor Author

rainest commented Dec 10, 2021

#1926 (comment) shows what this actually looks like.

Waiting for others to take a look since this could almost certainly use some changes.

@rainest rainest merged commit 6aa062f into main Jan 3, 2022
@rainest rainest deleted the feat/grafana branch January 3, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Grafana dashboard for controller Prometheus metrics
2 participants