Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEP-957: Gateway port matching for Gateway API UDPRoute #3237

Closed
3 tasks done
czeslavo opened this issue Dec 8, 2022 · 1 comment · Fixed by #3832
Closed
3 tasks done

GEP-957: Gateway port matching for Gateway API UDPRoute #3237

czeslavo opened this issue Dec 8, 2022 · 1 comment · Fixed by #3832
Assignees
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API size/medium
Milestone

Comments

@czeslavo
Copy link
Contributor

czeslavo commented Dec 8, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

Implement gateway port matching for Gateway API UDPRoute as it was defined in https://gateway-api.sigs.k8s.io/geps/gep-957/ and implemented in kubernetes-sigs/gateway-api#1002.

Proposed Solution

Check in the UDPRoute controller whether the route has been accepted by any listener and remove it from the Kong store if not.

Additional information

Blocked by #2544 (needed for proper testing of the functionality and making a single Gateway capable of serving both TCP and UDP routes).

Acceptance Criteria

  • When UDPRoute's BackendObjectReference specifies a Port that doesn't match any Listener in the Gateway, it's not accepted (not in the webhook: Parser rejects it and sets an appropriate GWAPI condition)
  • UDPRouteEssentials integration test is updated to cover port matching
@czeslavo
Copy link
Contributor Author

Removing blocked label as #3325 is resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API size/medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants