Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port projected volume SA token from chart #3475

Closed
2 tasks
rainest opened this issue Feb 2, 2023 · 3 comments · Fixed by #3563
Closed
2 tasks

Port projected volume SA token from chart #3475

rainest opened this issue Feb 2, 2023 · 3 comments · Fixed by #3563
Assignees
Milestone

Comments

@rainest
Copy link
Contributor

rainest commented Feb 2, 2023

Kong/charts#722 added support for the modern projected volume system to the chart. We should update the deployment manifests here to use the same.

Acceptance:

  • The KIC deploy manifests use a projected volume for their ServiceAccount tokens.
  • The projected volume configuration matches the configuration used in the chart.
@rainest rainest added this to the KIC v2.9.0 milestone Feb 2, 2023
@rainest
Copy link
Contributor Author

rainest commented Feb 2, 2023

Stuffing this in 2.9 for now since it should just be copy/paste from the chart unless we discover that there's some unexpected issue and need to rework the design.

@pmalek
Copy link
Member

pmalek commented Feb 2, 2023

It just occurred to me that when doing this we'll be cutting out users using k8s older than 1.20.

Unless there's a mechanism in kustomize - that I'm not aware of - to make a manifest be included conditionally based on k8s version (which you can do in helm).

@seh
Copy link
Contributor

seh commented Feb 2, 2023

Unless there's a mechanism in kustomize

There is no such mechanism, given that kustomize is not a client of the Kubernetes API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants