Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcilers should use an interface for dataplane client instead of tightly coupling with dataplane.KongClient #3794

Closed
pmalek opened this issue Mar 22, 2023 · 0 comments · Fixed by #4383

Comments

@pmalek
Copy link
Member

pmalek commented Mar 22, 2023

Problem statement

Currently most of the reconcilers use *dataplane.KongClient field for interaction with dataplane.

This creates a tight coupling and makes it hard to test.

#3759 introduced DataPlane interface (which can be moved to a more appropriate place if it's needed by non gateway reconcilers).

The proposal is to use this instead of concrete type *dataplane.KongClient to allow easier testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants