Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch and store current valid configuration from Proxy #4264

Closed
1 of 2 tasks
mlavacca opened this issue Jul 3, 2023 · 0 comments · Fixed by #4265
Closed
1 of 2 tasks

Fetch and store current valid configuration from Proxy #4264

mlavacca opened this issue Jul 3, 2023 · 0 comments · Fixed by #4265
Assignees
Labels
area/feature New feature or request
Milestone

Comments

@mlavacca
Copy link
Member

mlavacca commented Jul 3, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

#4205 enabled the Kong configuration store and push mechanism by caching the last valid configuration and pushing it to the proxy when the current configuration is broken, and the proxy has no good configuration loaded.

When the current configuration is broken, and KIC restarts for whatever reason, however, there are no means to restore the last good configuration from the controller itself, as the last previous good one was stored in KIC's memory.

Proposed Solution

To overcome the issue described above, when KIC has no previous good configuration stored in memory, we can fetch the good configuration from the proxy (if any) and store it. In this way, we basically treat Kong as the source of truth when all the last good config handlers are lost.

Additional information

This approach should be limited to dbless-mode only, as it is no possible to fetch the last good configuration in db-mode.

Acceptance Criteria

  • When KIC has no last good configuration stored, and there is a Kong proxy pod with a good configuration loaded, KIC is able to fetch it and cache it as the last good one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants