Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support conformance test GatewaySecretInvalidReferenceGrant #4916

Closed
1 of 2 tasks
randmonkey opened this issue Oct 20, 2023 · 1 comment · Fixed by #4981
Closed
1 of 2 tasks

Support conformance test GatewaySecretInvalidReferenceGrant #4916

randmonkey opened this issue Oct 20, 2023 · 1 comment · Fixed by #4981
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API blocked kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API
Milestone
KIC v3.0.x

Comments

@randmonkey
Copy link
Contributor

randmonkey commented Oct 20, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

Support core conformance test GatewaySecretInvalidReferenceGrant added in gateway API 1.0.0-rc1. This conformance test is required for feature SupportReferenceGrant.

Proposed Solution

No response

Additional information

blocked by release of gateway API to include the fixing commit kubernetes-sigs/gateway-api@fcb0bc4

Acceptance Criteria

  • passes conformance test GatewaySecretInvalidReferenceGrant.
@randmonkey randmonkey added blocked area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API labels Oct 20, 2023
@randmonkey randmonkey added this to the KIC v3.0.0 milestone Oct 20, 2023
@randmonkey
Copy link
Contributor Author

randmonkey commented Oct 20, 2023 •
edited
Loading

In gateway 1.0.0-rc1, manifests in the conformance tests has a mistake: APIVersion of RefereceGrant s are set to gateway.networking.k8s.io/v1 . The revert commit is here: kubernetes-sigs/gateway-api@fcb0bc4
This commit is included in main branch of gateway API, but not 1.0.0-rc1 yet. When the commit is included in some tags, we could simply bump to that tag and get this resolved.

@randmonkey randmonkey mentioned this issue Oct 26, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API blocked kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API
Projects
None yet
Milestone
KIC v3.0.x
Development

Successfully merging a pull request may close this issue.

chore: bump gateway APIs to 1.0.0-rc2 Kong/kubernetes-ingress-controller
1 participant
@randmonkey