Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support extended, experimental field Spec.CommonRouteSpec.ParentRefs[*].Port in TCPRoute & UDPRoute #4958

Closed
1 of 3 tasks
programmer04 opened this issue Oct 25, 2023 · 1 comment · Fixed by #5235
Assignees
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API onboarding priority/low

Comments

@programmer04
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

Currently only field Spec.CommonRouteSpec.ParentRefs[*].SectionName is properly supported, see

that fixes

Setting Spec.CommonRouteSpec.ParentRefs[*].Port does not have any effect. It should work as described in the specification.

Proposed Solution

Implement support for Port field as described in the gateway-api spec.

Additional information

Conformance tests in gateway-api repo for checking this doesn't exist when it was been written. Ensure that is properly tested, consider adding such test to the upstream.

Acceptance Criteria

  • field Spec.CommonRouteSpec.ParentRefs[*].Port works as described in spec for TCPRoute & UDPRoute
  • it is properly tested
@programmer04 programmer04 added area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API labels Oct 25, 2023
@pangruoran
Copy link
Contributor

Could you please assign this to me? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API onboarding priority/low
Projects
None yet
4 participants