Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch e2e tests to use Helm chart instead of all-in-one manifests #4973

Open
1 of 3 tasks
programmer04 opened this issue Oct 25, 2023 · 3 comments
Open
1 of 3 tasks
Labels
area/debt area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests priority/medium
Milestone

Comments

@programmer04
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

E2E tests rely on manifests stored in test/e2e/manifests/ and generated with scripts/build-single-manifests.sh. Get rid of those manifests and related code/configuration, and replace them with the usage of Helm chart.

Proposed Solution

  • manifests are removed, Helm chart is used

Additional information

Continuation of

Acceptance Criteria

  • content of test/e2e/manifests is removed and all related code and configuration too
  • e2e tests use Helm chart
@lahabana
Copy link
Contributor

lahabana commented Jun 5, 2024

@programmer04 isn't there a chicken and egg problem here? As in we don't have a helm chart because the software isn't released yet?

Should we just set --set ingressController.image.tag (https://github.com/Kong/charts/blob/fd9deb6ee34d9b9ac4ab4be2188d4564d0b655e5/charts/kong/values.yaml#L535C1-L536C1) or maybe there's something I fundamentally miss on how e2e tests work?

@lahabana lahabana modified the milestones: KIC v3.2.x, KIC v3.3.x Jun 5, 2024
@randmonkey
Copy link
Contributor

IHAC when we updated the CRDs (bump gateway API version or update own CRDs), we will have to update helm charts before the release that can really compatible with these CRDs. This may make the charts unavailable.

@programmer04
Copy link
Member Author

You're right @lahabana setting image explicitly is the way to go

@lahabana lahabana modified the milestones: KIC v3.3.x, KIC v3.4.x Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/debt area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/tests priority/medium
Projects
None yet
Development

No branches or pull requests

4 participants