Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address possible blocking calls in forwarders #47

Open
pmalek opened this issue Aug 11, 2022 · 0 comments
Open

Address possible blocking calls in forwarders #47

pmalek opened this issue Aug 11, 2022 · 0 comments

Comments

@pmalek
Copy link
Member

pmalek commented Aug 11, 2022

As of now the forwarders don't use a context.Context as an argument to Forward().

This might cause issues like blocking other pieces of code whenever the consumer of the report being forwarded do not respond in a timely manner.

This could also be a problem in implementations like rawChannelForwarder where the consumer is responsible for consumption of the report in timely manner and if that's not the case then the whole pipeline can stall.

Related comment from a review: #45 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant