Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension - Add Swap button #2784

Closed
Sokol142196 opened this issue Mar 21, 2024 · 5 comments · Fixed by #2789 or #2802
Closed

Extension - Add Swap button #2784

Sokol142196 opened this issue Mar 21, 2024 · 5 comments · Fixed by #2789 or #2802
Assignees
@dungnguyen-art

Comments

@Sokol142196
Copy link

Sokol142196 commented Mar 21, 2024 •
edited

Describe the task
Add Swap button for extension
@Sokol142196 Sokol142196 assigned lw-cdm and dungnguyen-art and unassigned lw-cdm Mar 21, 2024
@dungnguyen-art dungnguyen-art mentioned this issue Mar 22, 2024
Merged
@dungnguyen-art dungnguyen-art linked a pull request Mar 22, 2024 that will close this issue
[Issue-2784] Extension - Add Swap button #2789
Merged
@haiyenvu23
Copy link

haiyenvu23 commented Mar 22, 2024 •
edited by dungnguyen-art

Version test : http://14.224.158.246:8900/s/NnseSxLo5T9rFkJ

  • In case there is no account in the wallet , after click button -> Navigate to the Swap feature on WebApp
    Actual : After create new account then navigate to Home screen
    Expect : After create new account then navigate to Swap screen

Image

  • In case specific account mode, after click button -> Navigate to the Swap feature on WebApp
    Actual : Can not auto select account
    Expect : Auto select account

Image

@dungnguyen-art dungnguyen-art mentioned this issue Mar 25, 2024
Merged
@dungnguyen-art dungnguyen-art linked a pull request Mar 25, 2024 that will close this issue
[Issue-2784] handle to add swap button to Extension #2802
Merged
@haiyenvu23
Copy link

Version test : http://14.224.158.246:8900/s/98NJQ5W9t8PARqE
Link test : https://webapp-dev.subwallet-webapp.pages.dev/redirect-handler/swap

Validation passed in case :

  • The wallet does not have an account

Image

  • The wallet has an account

Image

@haiyenvu23
Copy link

haiyenvu23 commented Mar 27, 2024 •
edited by dungnguyen-art

Version test : http://14.224.158.246:8900/s/98NJQ5W9t8PARqE

  • UI bug when balance is long
    Expect : When scroll screen, temporarily hide the Buy button

Image

@haiyenvu23
Copy link

haiyenvu23 commented Mar 28, 2024 •
edited by dungnguyen-art

Version test : http://14.224.158.246:8900/s/krZwCQE2zHtedKZ

  • Align it close to the margin

Image

  • UI bug when balance is long on Token detail screen
    Expect : When scroll screen, temporarily hide the Buy button

Image

  • Only remove button Buy when the balance affects the UI

Image

@haiyenvu23
Copy link

Version test : http://14.224.158.246:8900/s/7faFXeK98WQb8Nd
Validation passed

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dungnguyen-art dungnguyen-art

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dungnguyen-art @lw-cdm @Sokol142196 @haiyenvu23