Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check transfer logic that can potentially affect ED #2798

Closed
3 tasks done
nampc1 opened this issue Mar 25, 2024 · 4 comments · Fixed by #2813
Closed
3 tasks done

Check transfer logic that can potentially affect ED #2798

nampc1 opened this issue Mar 25, 2024 · 4 comments · Fixed by #2813
Assignees
@nampc1
Labels
critical-error Critical error need to be fixed ASAP
Milestone
Milestone 7

Comments

@nampc1
Copy link

nampc1 commented Mar 25, 2024 •
edited by Sokol142196

  • Transfer
  • Transfer max
    • Transfer Max = Transferable - fee
    • When transfer Max then show warning
  • XCM
    • Transfer Max (XCM) = Transferale - ED * 1.2 - fee * 2
@nampc1 nampc1 self-assigned this Mar 25, 2024
@nampc1 nampc1 added the critical-error Critical error need to be fixed ASAP label Mar 25, 2024
@nampc1
Copy link
Author

nampc1 commented Mar 26, 2024

With XCM, we should limit the maximum transferable to prevent unwanted side effects of losing assets
With normal transfer, we should show a warning upon transfer all to alert users of potential asset loss

@nampc1
Copy link
Author

nampc1 commented Mar 26, 2024

Also need to check nomination pool staking validation

@nampc1
Copy link
Author

nampc1 commented Mar 26, 2024

Message to warn about asset loss

Header: Pay attention!
Message: Transferring all will remove all assets on this network. Are you sure?
Button: Cancel / Transfer

@S2kael S2kael mentioned this issue Mar 26, 2024
Merged
@S2kael S2kael linked a pull request Mar 26, 2024 that will close this issue
[Issue-2798] Check transfer logic that can potentially affect ED #2813
Merged
@ThaoNguyen998
Copy link

Version test: http://14.224.158.246:8900/s/4izMAcBS6FYkA87
Validation passed

  • Transfer
  • Transfer max
  • XCM max
  • Add popup warning

image

image

image

image

@ThaoNguyen998 ThaoNguyen998 added this to the Milestone 7 milestone Mar 26, 2024
@haiyenvu23 haiyenvu23 mentioned this issue Mar 27, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nampc1 nampc1

Labels
critical-error Critical error need to be fixed ASAP
Projects
None yet
Milestone
Milestone 7
Development

Successfully merging a pull request may close this issue.

[Issue-2798] Check transfer logic that can potentially affect ED Koniverse/SubWallet-Extension
2 participants
@nampc1 @ThaoNguyen998