Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension - Implement UI for export multi-account #2819

Closed
2 tasks done
haiyenvu23 opened this issue Mar 27, 2024 · 8 comments · Fixed by #2700
Closed
2 tasks done

Extension - Implement UI for export multi-account #2819

haiyenvu23 opened this issue Mar 27, 2024 · 8 comments · Fixed by #2700
Assignees
Milestone

Comments

@haiyenvu23
Copy link

haiyenvu23 commented Mar 27, 2024

Describe the bug
Implement UI for export according to the selected account list

@haiyenvu23
Copy link
Author

haiyenvu23 commented Mar 27, 2024

Version test : http://14.224.158.246:8900/s/aKbjTry73BGg5Ei

  • Add "s" to the word "account" when choose > 1 account

Image

  • Add condition when input password

Image

  • Display wrong address of EVM account

Image

@haiyenvu23
Copy link
Author

haiyenvu23 commented Mar 28, 2024

Version test : http://14.224.158.246:8900/s/mYp4pGmre2ibTpp

  • Change message "Invalid master password" -> "Wrong password"

Image

  • Change message for case import Ledger account on Firefox browser
  • Content : " Incompatible browser. Use a Chrominum based browser like Chrome and Brave and try again."

Image

  • Update icon

Image

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Mar 29, 2024

Version test: http://14.224.158.246:8900/s/9FidzeZ3xwJJGF6

  • Do not reset selected items in case re-open Export account screen
    Steps:
  1. Open Export account screen
  2. Select account
  3. Back to Select account screen
  4. Re-open Export account screen and observe the displayed screen

Actual: Do not reset selected items

Image

Expect: Reset selected items

  • Update message when perform sign Transaction with dApp for case Ledger account on Firefox browser

Image

@haiyenvu23
Copy link
Author

haiyenvu23 commented Mar 29, 2024

Version test : http://14.224.158.246:8900/s/LMdcJNipLJigTM9

  • Display error when perform Transaction

Image

@haiyenvu23
Copy link
Author

Version test : http://14.224.158.246:8900/s/FSpNCxgKWYQ4a4P
Validation passed in case :

  • Add message for case import Ledger account on Firefox browser

Image

Image

  • Support select account to export

Image

  • Check result export - import when the wallet has >= 1 Substrate account
  • Check result export - import when the wallet has >= 1 EVM account
  • Check result export - import when the wallet has both Substrate and EVM accounts
  • Check result export - import when the wallet contains an attached account (watch only, ledger, polkadot vault)
  • Check when making transactions with export files from SubWallet (performed on SubWallet , Polkadot js, Talisman)

Image

@haiyenvu23
Copy link
Author

haiyenvu23 commented Apr 1, 2024

  • Added tooltip for button icon

image

  • Wrong size of Export account button in Select account screen

image

  • Automatically tick the "All accounts" option when all accounts in the list are ticked

image

  • Disable account export button when no account has been selected

image

  • Change the style of the Incompatible browser notification to error type

image

@haiyenvu23
Copy link
Author

haiyenvu23 commented Apr 4, 2024

Version test : http://14.224.158.246:8900/s/Np4dBbTxf29tC3N

  • Change the style of the Incompatible browser notification to error type when perform transaction ( with Ledger account on Firefox)

Image

  • Tooltip is missing a corner

Image

  • Displays the address of the Ledger account according to the network

Image

@haiyenvu23
Copy link
Author

Version test : http://14.224.158.246:8900/s/8jgHEZc2PD4Hm6w
Validation passsed in case :

Image

  • Change the style of the Incompatible browser notification to error type when perform transaction ( with Ledger account on Firefox)

Image

  • Displays the address of the Ledger account

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants