Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deeplink (Add more deeplink type) (Round 2) #1070

Closed
1 task done
ThaoNguyen998 opened this issue Oct 12, 2023 · 2 comments · Fixed by #1141
Closed
1 task done

Improve deeplink (Add more deeplink type) (Round 2) #1070

ThaoNguyen998 opened this issue Oct 12, 2023 · 2 comments · Fixed by #1141
Assignees
@Quangdm-cdm
Milestone
Milestone 6

Comments

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Oct 12, 2023 •
edited

@ThaoNguyen998 ThaoNguyen998 added this to the Milestone 7 milestone Oct 12, 2023
@ThaoNguyen998
Copy link
Author

ThaoNguyen998 commented Oct 12, 2023 •
edited

  • The scan QR screen doesn't close automatic when open app with deeplink
  • Bug when open Subwallet app with deeplink
    Steps:
  1. Open SubWallet app
  2. Open any modal: Receive, Select account type, ...
  3. Re-open app with deeplink Token detail and observe the displayed sceen
    Actual: Modal Receive overlap token detail screen
    https://konistudio-my.sharepoint.com/:v:/g/personal/nhungphung_koni_studio/EWtqtJwYv-5Ii3U7G1Om7v0Bz_ThgfDEAcmjixiWD5ubGQ?nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJPbmVEcml2ZUZvckJ1c2luZXNzIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXciLCJyZWZlcnJhbFZpZXciOiJNeUZpbGVzTGlua0RpcmVjdCJ9fQ&e=mPKHxj
    Expect: Auto turn off modal and show Token detail
  • Bug when open deeplink NFT detail
    • Case 1: Can't open list NFT in case open app with deeplink Token detail
      Steps:
  1. Open app with deeplink Token detail
  2. Perform open app with deeplink NFT list
  3. Obverse the displayed screen
    Actual: Navigate Tokens screen
    https://konistudio-my.sharepoint.com/:v:/g/personal/nhungphung_koni_studio/EZHhX_jhXylBiqUmg-_B3SYBQvg5vDNOdF6FI7N9g2pJtg?nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJPbmVEcml2ZUZvckJ1c2luZXNzIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXciLCJyZWZlcnJhbFZpZXciOiJNeUZpbGVzTGlua0RpcmVjdCJ9fQ&e=3WOhbu
    Expect: Navigate NFT list screen

@Sokol142196 Sokol142196 mentioned this issue Oct 12, 2023
Closed
@Sokol142196 Sokol142196 modified the milestones: Milestone 7, Milestone 8 Nov 9, 2023
@Quangdm-cdm Quangdm-cdm mentioned this issue Nov 9, 2023
Merged
@Quangdm-cdm Quangdm-cdm linked a pull request Nov 9, 2023 that will close this issue
[issue-1070] Improve deeplink (Add more deeplink type) (Round 2) #1141
Merged
@ThaoNguyen998
Copy link
Author

ThaoNguyen998 commented Nov 14, 2023 •
edited

Version test: PR #1141 16:26 09/11/2023
Device test: IP 11

Validation pass in case:

  • NFT list
  • Token detail
  • In app browser
  • Staking
  • Staking detail

@ThaoNguyen998 ThaoNguyen998 reopened this Nov 16, 2023
@ThaoNguyen998 ThaoNguyen998 reopened this Nov 24, 2023
@hieudd hieudd modified the milestones: Milestone 8, Milestone 7, Milestone 6 Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Quangdm-cdm Quangdm-cdm

Labels
None yet
Projects
None yet
Milestone
Milestone 6
Development

Successfully merging a pull request may close this issue.

[issue-1070] Improve deeplink (Add more deeplink type) (Round 2) Koniverse/SubWallet-Mobile
4 participants
@hieudd @Quangdm-cdm @ThaoNguyen998 @Sokol142196