Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Readonly Account #140

Closed
8 tasks done
saltict opened this issue Oct 17, 2022 · 3 comments · Fixed by #171 or #207
Closed
8 tasks done

Support Readonly Account #140

saltict opened this issue Oct 17, 2022 · 3 comments · Fixed by #171 or #207
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@saltict
Copy link
Contributor

saltict commented Oct 17, 2022

Readonly account to checking account balance, NFT...

Basic Implementation

  • Add an external account
    • Readonly account address
    • Support input address with QR
    • Support both substrate and EVM account
  • Add metadata to read-only account `{isReadOnly: false}
  • Add read-only account

Update for Transaction

  • Prevent with actions that required signature like transfer, sign... to this type of account
  • Warning that this read-only is not ready to create signature
@saltict saltict added enhancement New feature or request mobile labels Oct 17, 2022
@saltict saltict added this to the Milestone 4 milestone Oct 17, 2022
@saltict saltict assigned Quangdm-cdm and S2kael and unassigned Quangdm-cdm Oct 17, 2022
@S2kael S2kael linked a pull request Oct 28, 2022 that will close this issue
@sokol142
Copy link

sokol142 commented Nov 7, 2022

version test: v0.2.1 (94)

Please check issue:

  • Can't use app after sign with Readonly account
    image

Expected: Do not show the read-only account on the pop-up connect confirmation

  • Update account type on the Network Selection screen:

    • Get wallet address: Stand on "All Accounts" mode then click on Receive button)
    • Select "From Account" to send assets: Stand on "All Accounts" mode then go to Send asset screen
    • Current Account
    • List account connect to dApp: Setting > Security > Manage Dapp Access screen
  • Update message when send asset with Read-only account

  • Expected: Change to message: "The account you are using is read-only, you cannot send assets with it"

@saltict
Copy link
Contributor Author

saltict commented Nov 7, 2022

  • Display coming soon title when click to attach QR signer

@S2kael S2kael linked a pull request Nov 8, 2022 that will close this issue
@sokol142
Copy link

sokol142 commented Nov 8, 2022

Version test: v0.2.1 (97)

Validation passed in cases:

  • Attach account/ Edit account/ Remove account
  • Send assets: show warning when send asset
  • View NFT: do not show Send NFT button
  • View staking: do not show buttons
  • Connect to dApp: Do not show Readonly on the account list to connect to dApp

@sokol142 sokol142 closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants