Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Master Password in Keychain #444

Closed
nguyenduythuc opened this issue Apr 20, 2023 · 5 comments · Fixed by #835
Closed

Save Master Password in Keychain #444

nguyenduythuc opened this issue Apr 20, 2023 · 5 comments · Fixed by #835
Assignees
Milestone

Comments

@nguyenduythuc
Copy link
Contributor

nguyenduythuc commented Apr 20, 2023

  • Check() = check biometrics availability
  • Set() = set credential to keychain
  • Get() = get credential from keychain
  • Reset() = Remove from keychain

User flows:

  • Login screen/Unlock modal:

    • Check() to show authenticate by biometrics
    • Call Get() for authenticate by biometrics
    • Auto migrate with Set() in case user update app and enabled biometrics before
  • Turn on/off authenticate by biometrics:

    • Check() => Set() to turn on biometrics
    • Reset() to turn off biometrics
  • Change master password:

    • Check() => Set()

* Keychain use locally, not sync to cloud

@Sokol142196
Copy link

Sokol142196 commented Jul 26, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-203-835-merge-2023-07-24T03-52-46.ipa

Please check the issues:

  • Show the Login screen although do not create a master password yet
    • Expect: Show the welcome screen and require create master password
  • Can not close the approve confirmation screen if close enter password modal
    • Record bug: https://share.icloud.com/photos/00fojiJrUcTfzzkiqdIcthnPw

    • Steps:

      1. Setting Face ID/ Touch ID is enable
      2. Go to the Send fund screen
      3. Input valid data for the all fields then touch on Submit button
      4. Then touch on Approve button
      5. Close the Enter password popup
      6. Observe the screen displayed
    • Actual: Can not close the confirmation screen

  • Can't open app via Touch ID/Face ID although Face ID/ Touch ID setting is enable
    • Steps:

      1. Setting Face ID/ Touch ID is enable
      2. Close the app
      3. Re-open app
      4. Observe the screen displayed
    • Actual: Do not unlock wallet by Touch ID/ FaceID option

    • Expect: Show the popup unlock wallet by Touch ID/ FaceID

  • Unable to lock wallet manually if Face ID/ Touch ID setting = OFF
    • Expect: Enable Lock wallet manually
  • Unable to setting auto-lock timing if Face ID/ Touch ID setting = OFF
    • Expect: Enable setting auto-lock timing

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Aug 18, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-207-835-merge-2023-08-16T10-16-17.ipa
Devices test: IP 11

  • Do not apply biometric in case export account
  • Do not hide keyboard in case import account
    Steps:
  1. Go to Send fund screen and enable keyboard
  2. Perform import account successfully
  3. Observe the displayed screen

Actual: Do not hide the keyboard
https://share.icloud.com/photos/04eXmrB0ONmr0FVzdbcxVd1wQ

  • UI bug

Image

  • UI bug

Image

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Aug 21, 2023

@nguyenduythuc Please re-check this issue

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-209-835-merge-2023-08-21T02-00-50.apk
Devices test: Samsung S20 FE 5G

  • Do not input a password in case cancel biometric
    Steps:
  1. Go to Send Fund screen
  2. On the Confirmation screen, touch Cancel biometric
  3. Observe the displayed screen

Actual:

Screen_Recording_20230821_102634_SubWallet.mp4
  • Re-check time App lock

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Aug 23, 2023

@nguyenduythuc Please re-check
Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-209-835-merge-2023-08-23T08-09-42.apk
Device test: MI 8 Lite

  • Show message Un-lock failed
    Steps:
  1. Go to the Security settings screen
  2. Enable config Face ID/ Touch ID
  3. In input Touch ID screen, touch the Cancel button
  4. Close the app and re-open the app
  5. Observe the displayed screen

Actual: Show message Unlock false

444.mp4

On IOS: Disable config Face ID/Touch ID

Image

  • Can't open the app with Face ID when update version
    Pre-condition: Old version enable Face ID config

Steps:

  1. Perform updated version
  2. Use Face ID to open the app
  3. Observe the displayed screen

Actual: Can't open the app https://bit.ly/3F4I0hO

  • Bug in case cancel config allow camera
  • Do not active config Auto-lock

@Sokol142196
Copy link

Sokol142196 commented Sep 5, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-212-835-merge-2023-08-31T09-37-38.ipa

Device test: IP 8 Plus (15.5)

Please check the issues:

  • Bugs when connecting with WalletConnect
  • Update the clickable area of the Forgot password button
  • Handling cases of incorrect biometric authentication more than the specified number of times
    • Actual: Click using your biometric then do not show a popup to unlock
    • Expect: If enter incorrect biometric authentication more than the specified number of times then show popup notify to user about this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants