Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner doesn't render correctly - probably performance issue #4

Open
KonradLinkowski opened this issue Oct 8, 2021 · 5 comments
Open
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@KonradLinkowski
Copy link
Owner

Spinner renders as a dot, where it should be a circle arc
It is probably caused by the main thread blocking, but I'm not sure.

current behavior expected behavior
bad-cropped good-cropped
@KonradLinkowski KonradLinkowski added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 8, 2021
@drishtigehi
Copy link

@KonradLinkowski I would like to work on this issue

@KonradLinkowski
Copy link
Owner Author

@drishtigehi how is it going?
I created a PR for this, but it's rather a workaround than a fix.
I'm with merging for you, maybe you will fix this without changing the spinner.

@drishtigehi
Copy link

drishtigehi commented Oct 9, 2021

@KonradLinkowski It's going good. I've got a simple fix (without changing the spinner), but it's messing up the spinner's position. I'll remedy that and raise a PR.

@drishtigehi
Copy link

The spinner should be in the center of the image?

@KonradLinkowski
Copy link
Owner Author

The spinner should be in the center of the image?

There is an overlay for the entire screen so the user cannot change options while loading.
The spinner is in the center of the screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants