You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am currently thinking about changing the semantics regarding VC rewrites (or rewrites in general) for Kalamar.
At the moment when a rewrite is performed by Kustvakt, e.g. by adding constraints to the VC for access restrictions, these rewrites are shown in the VC builder as normal constraints and reported as rewrites by small icons attached to the constraint (Known bug). Now if a new request is made that includes the rewritten VC, e.g. searching for another term, the VC is serialized like all rewritten constraints were created by the user. That means, in the following requests the rewrites are no longer reported as rewrites.
My idea to make rewrites more transparent to the user is: Whenever a VC is send to the backend, first it will revert all rewrites performed on this VC (depending on #51). All constraints that were rewritten will have a distinct color in the VC builder, to make clear that these constraints won't be serialized as they are. By clicking on a special button (or on the rewrite button), the rewrite report will be deleted and the constraint will be treated as a user-created constraint.
As a side effect, this is also more in line with how rewrites are serialized for queries.
The text was updated successfully, but these errors were encountered:
I am currently thinking about changing the semantics regarding VC rewrites (or rewrites in general) for Kalamar.
At the moment when a rewrite is performed by Kustvakt, e.g. by adding constraints to the VC for access restrictions, these rewrites are shown in the VC builder as normal constraints and reported as rewrites by small icons attached to the constraint (Known bug). Now if a new request is made that includes the rewritten VC, e.g. searching for another term, the VC is serialized like all rewritten constraints were created by the user. That means, in the following requests the rewrites are no longer reported as rewrites.
My idea to make rewrites more transparent to the user is: Whenever a VC is send to the backend, first it will revert all rewrites performed on this VC (depending on #51). All constraints that were rewritten will have a distinct color in the VC builder, to make clear that these constraints won't be serialized as they are. By clicking on a special button (or on the rewrite button), the rewrite report will be deleted and the constraint will be treated as a user-created constraint.
As a side effect, this is also more in line with how rewrites are serialized for queries.
The text was updated successfully, but these errors were encountered: