Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong user credentials lead to server failure in OAuth2 password grant flow #45

Closed
Akron opened this issue Jun 26, 2019 · 0 comments
Closed

Wrong user credentials lead to server failure in OAuth2 password grant flow #45

Akron opened this issue Jun 26, 2019 · 0 comments
Assignees
@margaretha

Comments

@Akron
Copy link
Member

Akron commented Jun 26, 2019

When sending wrong username or password info to /oauth2/token, the server response with:

HTTP/1.1 500 Server Error
Cache-Control: must-revalidate,no-cache,no-store
Content-Type: text/html;charset=iso-8859-1
Content-Length: 4654
Connection: close
Server: Jetty(9.4.z-SNAPSHOT)

<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
<title>Error 500 Server Error</title>
</head>
<body><h2>HTTP ERROR 500</h2>
<p>Problem accessing /api/v1.0/oauth2/token. Reason:
<pre>    Server Error</pre></p><h3>Caused by:</h3><pre>java.lang.NullPointerException
\x09at de.ids_mannheim.korap.web.OAuth2ResponseHandler.throwit(OAuth2ResponseHandler.java:90)
\x09at de.ids_mannheim.korap.web.OAuth2ResponseHandler.throwit(OAuth2ResponseHandler.java:83)
\x09at de.ids_mannheim.korap.web.controller.OAuth2Controller.requestAccessToken(OAuth2Controller.java:208)
\x09at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
\x09at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
\x09at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
\x09at java.lang.reflect.Method.invoke(Method.java:498)
\x09at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
\x09at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
\x09at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
\x09at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
\x09at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
\x09at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
\x09at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
\x09at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
\x09at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
\x09at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
\x09at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
\x09at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
\x09at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
\x09at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)
\x09at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)
\x09at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
\x09at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:865)
\x09at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:535)
\x09at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:255)
\x09at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1340)
\x09at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:203)
\x09at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:473)
\x09at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:201)
\x09at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1242)
\x09at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:144)
\x09at org.eclipse.jetty.server.handler.HandlerList.handle(HandlerList.java:61)
\x09at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
\x09at org.eclipse.jetty.server.Server.handle(Server.java:503)
\x09at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:364)
\x09at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:260)
\x09at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:305)
\x09at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103)
\x09at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:118)
\x09at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:333)
\x09at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:310)
\x09at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:168)
\x09at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:126)
\x09at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:366)
\x09at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:765)
\x09at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:683)
\x09at java.lang.Thread.run(Thread.java:748)
</pre>
<hr><a href="http://eclipse.org/jetty">Powered by Jetty:// 9.4.z-SNAPSHOT</a><hr/>

</body>
</html>

Expected behaviour: Return a json object with error and error_description with a status 401 response.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@margaretha margaretha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Akron @margaretha