Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the objects magnitudes #6

Open
Deuchnord opened this issue Feb 21, 2020 · 1 comment
Open

Add the objects magnitudes #6

Deuchnord opened this issue Feb 21, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@Deuchnord
Copy link
Member

Deuchnord commented Feb 21, 2020

Is your feature request related to a problem? Please describe.
An object being risen does not necessarily mean it is visible enough for an observation. Its visibility actually heavily depends on its apparent magnitude.

Describe the solution you'd like
Provide a function that gives, for given date and object, the apparent magnitude of that object from the point of view of the Earth.

The function would look like this:

def get_apparent_magnitude(object: Object, date = date.today()) -> float

The returned value is a float that represents the apparent magnitude of the given object.

Additional context

  • We should use Skyfield's planetary_magnitude() function to compute this, and return the average value for the date.
  • There are currently some limitations in the algorithm, as explained in the docs of Skyfield. When it returns NaN, we should throw an exception.
@Deuchnord

This comment was marked as outdated.

@Deuchnord Deuchnord transferred this issue from Kosmorro/kosmorro Mar 15, 2021
@Deuchnord Deuchnord added the enhancement New feature or request label Mar 17, 2021
@Deuchnord Deuchnord added this to the v0.13 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant