Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot make a part stackable #97

Closed
ihsoft opened this issue Nov 29, 2015 · 2 comments
Closed

Cannot make a part stackable #97

ihsoft opened this issue Nov 29, 2015 · 2 comments

Comments

@ihsoft
Copy link
Owner

ihsoft commented Nov 29, 2015

I tried to override stackable state for the stock batteries and found out interesting behavior: for Z-400 override doesn't work in spite of it works just fine for the other batteries. Those parts have no module so, I've defined override by the name:

    StackableItemOverride
    {
        partName = addWhatYouWantHere1
        partName = addWhatYouWantHere2
// Batteries
        partName = batteryPack
        partName = batteryBank
        partName = batteryBankMini
        partName = ksp_r_largeBatteryPack  // <== Z-400, doesn't work
        partName = batteryBankLarge
    }

The only difference between Z-400 and other battery names is underscore in the name. Can it be the issue?

@ihsoft
Copy link
Owner Author

ihsoft commented Dec 5, 2015

I've figure it out. In case of battery packs the real name is a namespace path. I.e. for ksp_r_largeBatteryPack it's actually ksp.r.largeBatteryPack. When specified like this everything is working fine. It makes sense to add a comment in settings.cfg. Or translating dots in the part name into underscores when checking in the plugin.

@ihsoft
Copy link
Owner Author

ihsoft commented Feb 18, 2016

Released in v1.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant