Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor translation issues #2

Open
ndfz opened this issue Jan 15, 2024 · 1 comment
Open

minor translation issues #2

ndfz opened this issue Jan 15, 2024 · 1 comment

Comments

@ndfz
Copy link

ndfz commented Jan 15, 2024

Hello! I noticed that when you change the language, a part of the FeatureTitle remains unchanged because the values of the title and subtitle fields are static.

image

Possible solutions could include:

FeatureTitle.vue

<script setup lang="ts">
export interface FeatureTitle {
  featureTitle: string;
  featureSubtitle: string;
}

defineProps<{
  data: FeatureTitle;
}>();
</script>

<template>
  <div class="FeatureTitle">
    <div class="container">
      <p v-if="data.featureTitle" class="title">
        <span v-html="data.featureTitle" class="title"></span>
      </p>
      <h1 v-if="data.featureSubtitle" class="subtitle">
        <span v-html="data.featureSubtitle" class="subtitle"></span>
      </h1>
    </div>
  </div>
</template>

Home.vue

<template>
  <template v-if="fm.main">
    <div class="container">
      <HomeHero :data="fm.main" />
      <FeatureTitle :data="fm.main" />
      <Features :features="fm.main.features" />
    </div>
  </template>
</template>

ua/index.md

main:
  title: Манґа у вашій кишені
  tagline: Проста і зручна програма для читання манґи з відкритим вихідним кодом від спільноти і для спільноти, де ви можете знайти і прочитати свою улюблену манґу простіше, ніж будь-коли.
  image:
    alt: Kotatsu Logo
    light: /phone_light.webp
    dark: /phone_dark.webp
  actions:
    - theme: brand
      text: Завантажити
      link: /ua/download/
    - theme: alt
      text: Посібники
      link: /ua/manuals/guides/getting-started/
  featureTitle: На що здатний Kotatsu?
  featureSubtitle: I ось на що він здатний!
  features:
    - image:
        alt: Feature Sources
        light: /img/feature_sources-light.webp
        dark: /img/feature_sources-dark.webp
      title: Величезна кількість джерел
      details: Підтримує понад 500+ джерел
@ztimms73
Copy link
Member

thank you, I'll look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants