Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K2] KMP: Support Wasm platform fully #3636

Closed
vmishenev opened this issue May 30, 2024 · 1 comment · Fixed by #3641
Closed

[K2] KMP: Support Wasm platform fully #3636

vmishenev opened this issue May 30, 2024 · 1 comment · Fixed by #3641
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888

Comments

@vmishenev
Copy link
Member

vmishenev commented May 30, 2024

Currently, Kotlin Wasm is Alpha.
Dokka analyzes it as JS platform. Dokka K1 does the same.

It is blocked by https://youtrack.jetbrains.com/issue/KT-64984/Analysis-API-Support-Wasm-target
(needs a LLFirAbstractSessionFactory implementation)

Testing: ??
WasmJsWasiGradleIntegrationTest will be passes if here

external interface TextLinkProps: AnchorHTMLAttributes<HTMLAnchorElement>

we remove AnchorHTMLAttributes (no import for it)
In Dokka K1 AnchorHTMLAttributes is just omitted

Parent: #3137

@vmishenev vmishenev added bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888 labels May 30, 2024
@vmishenev vmishenev changed the title [K2] KMP: Support Wasm klib [K2] KMP: Support Wasm platform May 30, 2024
@vmishenev vmishenev changed the title [K2] KMP: Support Wasm platform [K2] KMP: Support Wasm platform fully May 31, 2024
@vmishenev vmishenev linked a pull request Jun 3, 2024 that will close this issue
@vmishenev
Copy link
Member Author

We can analyze Wasm as JS platform if Dokka passes all dependencies. However, it depends on the internals/implementation of Analysis API. Currently, it works. After https://youtrack.jetbrains.com/issue/KT-64984/Analysis-API-Support-Wasm-target, it would be better to use the analysis for the Wasm platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant