Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion with two artifacts for android and non-android #458

Closed
ZacSweers opened this issue Apr 2, 2019 · 1 comment
Closed

Confusion with two artifacts for android and non-android #458

ZacSweers opened this issue Apr 2, 2019 · 1 comment
Labels
enhancement An issue for a feature or an overall improvement
Milestone

Comments

@ZacSweers
Copy link

I was recently working on integrating dokka into an android library, and despite being able to apply the plugin with no issues, sources/javadoc jars were strangely not getting generated. Finally after updating to 0.9.18, I suddenly would get a crash looking up a configuration that didn't exist. When tracing down this code, I noticed that it was emanating from the non-android plugin. This made me realize that the artifact used in my project was wrong, and finally resolved my jar generation after switching.

Is there a need for two artifacts? Especially when seemingly applying either plugin can be applied from the wrong artifact. https://github.com/square/sqldelight did something similar in the beginning and unified their plugin after the confusion it caused, and I'd be interested to know if there's a technical reason dokka has to have them separate.

@semoro semoro added the Gradle label May 16, 2019
@kamildoleglo kamildoleglo added the enhancement An issue for a feature or an overall improvement label Aug 28, 2019
@kamildoleglo kamildoleglo added this to the 0.9.19 milestone Aug 28, 2019
@kamildoleglo
Copy link
Contributor

Done in 1c4a3c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An issue for a feature or an overall improvement
Projects
None yet
Development

No branches or pull requests

3 participants