Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeAliases moved outside of external declarations files are lost #368

Closed
Schahen opened this issue Aug 14, 2020 · 1 comment
Closed

TypeAliases moved outside of external declarations files are lost #368

Schahen opened this issue Aug 14, 2020 · 1 comment
Labels
critical domain:typealias regression the most important thing for regressions is to figure out how they went unnoticed wontfix This will not be worked on
Milestone

Comments

@Schahen
Copy link
Contributor

Schahen commented Aug 14, 2020

Following code

declare module "hey" {
    interface Api {}
    type App = Api;
    function createApp(): App;
}

is converted to:

external interface Api

external fun createApp(): App

And fails since App is not defined.
However we used to move type aliases outside of JsModule-annotated file and this logic is obviously lost.

@Schahen Schahen added critical regression the most important thing for regressions is to figure out how they went unnoticed domain:typealias labels Aug 14, 2020
@Schahen Schahen added this to the 0.5.8 milestone Aug 14, 2020
@Schahen Schahen added the wontfix This will not be worked on label Aug 18, 2020
@Schahen
Copy link
Contributor Author

Schahen commented Aug 18, 2020

not a bug, was a build problem however investigation helped to pinpoint some different issues.

@Schahen Schahen closed this as completed Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical domain:typealias regression the most important thing for regressions is to figure out how they went unnoticed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant