Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *mavenLocal to default repositories? #100

Closed
breandan opened this issue Sep 3, 2020 · 2 comments
Closed

Add *mavenLocal to default repositories? #100

breandan opened this issue Sep 3, 2020 · 2 comments

Comments

@breandan
Copy link
Contributor

breandan commented Sep 3, 2020

When I first added a JSON dependency to a library published under Maven Local, the Kotlin Jupyter kernel was unable to resolve the dependency until I added *mavenLocal to the repositories section of the JSON manifest. Does it make sense to add *mavenLocal as a default repository?

Related to: #86

@ileasile
Copy link
Member

ileasile commented Sep 8, 2020

It's easy to do, but I'm not sure it's needed, because it reduces reproducibility of notebooks, and we try to increase it.

@altavir
Copy link
Contributor

altavir commented Sep 8, 2020

In general, using mavenLocal as default is a bad practice since it produces strange errors when you have different artifacts with the same version on remote and on local. I do not think it is a problem in the Jupyter environment since it is fluid. But I still think it is easier to turn it on with annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants