Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new kernel fails with python <3.8 #380

Open
ileasile opened this issue Aug 5, 2022 · 2 comments
Open

Adding new kernel fails with python <3.8 #380

ileasile opened this issue Aug 5, 2022 · 2 comments
Labels
bug Installation and functionality issues documentation good first issue help wanted

Comments

@ileasile
Copy link
Member

ileasile commented Aug 5, 2022

Fails because the unsupported feature is used in install script:

Installing kernel to /Users/pavel.gorgulov/Library/Jupyter/kernels/kotlin_JDK_11_kernel
Traceback (most recent call last):
  File "/opt/anaconda3/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/opt/anaconda3/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/opt/anaconda3/lib/python3.7/site-packages/kotlin_kernel/__main__.py", line 32, in <module>
    main(sys.argv)
  File "/opt/anaconda3/lib/python3.7/site-packages/kotlin_kernel/__main__.py", line 24, in main
    commands[command](args)
  File "/opt/anaconda3/lib/python3.7/site-packages/kotlin_kernel/__main__.py", line 5, in <lambda>
    commands = {'add-kernel': lambda x: add_kernel(x), 'detect-jars-location': 
  File "/opt/anaconda3/lib/python3.7/site-packages/kotlin_kernel/add_kernel.py", line 83, in add_kernel
    install_base_kernel(kernel_name)
  File "/opt/anaconda3/lib/python3.7/site-packages/kotlin_kernel/install_user.py", line 32, in install_base_kernel
    shutil.copytree(src, dst, dirs_exist_ok=True)
TypeError: copytree() got an unexpected keyword argument 'dirs_exist_ok'

Either state in the documentation that only python >= 3.8 should be used, or rewrite it to support lower versions.

@ileasile ileasile added bug Installation and functionality issues help wanted documentation good first issue labels Aug 5, 2022
@Cxxshyy
Copy link

Cxxshyy commented Oct 21, 2022

Hi id be looking to take this issue but could you give me some guidance on how i would rewrite it to be able to support lower versions

@EmmanuelDav
Copy link

@ileasile is this issue still Open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Installation and functionality issues documentation good first issue help wanted
Projects
None yet
Development

No branches or pull requests

3 participants