Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong coverage on DefaultImpls branch and instruction #149

Closed
LeoColman opened this issue Mar 5, 2022 · 8 comments
Closed

Wrong coverage on DefaultImpls branch and instruction #149

LeoColman opened this issue Mar 5, 2022 · 8 comments
Labels
Bug Bug issue type Kover Coverage Tool S: waiting for clarification Status: additional information required to proceed

Comments

@LeoColman
Copy link

Hey guys!
I'm trying to use Kover on simple-password-generator. I have an issue with the coverage (added as an attachment). Some bits of coverage is being reported as missing.

WordGenerator$DefaultImpls 100% (3/3) 87.5% (7/8) 100% (4/4) 89.4% (42/47)

report.zip

If you look at the code (and tests), you'll see that every scenario is covered. I tried to dig a bit of the bytecode generated under the hood, but was unsuccessful in finding these branches.

Reproducing

I froze this tag in the repository. Cloning it and running koverReport should be enough to reproduce this result.

@shanshin
Copy link
Collaborator

Thanks for the report!

@LeoColman
Copy link
Author

I'd love to work on this, but I don't have any pointer on where to start.
If you have ideas we can add them here :)

@shanshin
Copy link
Collaborator

@LeoColman, please check in 0.5.1

@shanshin shanshin added the S: waiting for clarification Status: additional information required to proceed label May 11, 2022
@shanshin
Copy link
Collaborator

Must be fixed since 0.5.1, feel free to reopen if the problem reproduced again.

@LeoColman
Copy link
Author

Sorry, I never saw your first message.
It's not fixed in 0.5.1, although the coverage report improved by a small amount.
image

I cloned the same tag I froze in the first comment and upgraded kover to 0.5.1. After running tests again the result is still the same

@LeoColman
Copy link
Author

Adding to that, I also tried with Kover 0.6.0 and the issue persists.

@shanshin shanshin reopened this Aug 24, 2022
@shanshin
Copy link
Collaborator

shanshin commented Sep 8, 2022

@LeoColman, I generated the report locally and I got this
image

please recheck your local build

@LeoColman
Copy link
Author

Hey @shanshin !
You're right. I reran locally and now it's 100% covered.
image

Thanks for all the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug issue type Kover Coverage Tool S: waiting for clarification Status: additional information required to proceed
Projects
None yet
Development

No branches or pull requests

2 participants