Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Java 9 Flow API #162

Closed
fvasco opened this issue Nov 12, 2017 · 5 comments
Closed

Support for Java 9 Flow API #162

fvasco opened this issue Nov 12, 2017 · 5 comments

Comments

@fvasco
Copy link
Contributor

fvasco commented Nov 12, 2017

Rename kotlinx-coroutines-reactive package to Java 9 package.

@elizarov
Copy link
Contributor

Why rename? kotlinx-coroutines-reactive support Reactive Streams specification interfaces. It does not work with Java 8 Flow.* interfaces. We should define a new module for that. The only tricking part is how name it: either kotlinx-coroutines-jdk9 or kotlinx-coroutines-flow.

@fvasco
Copy link
Contributor Author

fvasco commented Nov 12, 2017

Hi @elizarov,
I said that badly, I am fully agree with you.

Both names are nice,
I consider a bit better to offer a complete jdk 9 integration as a single dependency, however this goal can be reached by putting kotlinx-coroutines-flow as dependency of kotlinx-coroutines-jdk9.

@elizarov
Copy link
Contributor

What else there is to jdk 9 integration beyond Flow.* interfaces?

@fvasco
Copy link
Contributor Author

fvasco commented Nov 13, 2017

Nothing,
so I prefer the name kotlinx-coroutines-jdk9.

Flow api should not look different from time api.

@qwwdfsad
Copy link
Collaborator

Fixed in 1.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants